Skip to content

fix(core): consume response body in _flush() and _capture() to prevent CF Workers warnings #3211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jgarrison929 wants to merge 1 commit into from
Closed

fix(core): consume response body in _flush() and _capture() to prevent CF Workers warnings #3211

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 19 additions & 2 deletions packages/core/src/posthog-core-stateless.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -964,8 +964,16 @@ export abstract class PostHogCoreStateless {
}

try {
await this.fetchWithRetry(url, fetchOptions)
const res = await this.fetchWithRetry(url, fetchOptions)
// Consume the response body to prevent resource leaks in runtimes like
// Cloudflare Workers that require the body to be read before the handler completes.
// See: https://github.com/PostHog/posthog-js/issues/3173
await res.text().catch(() => {})
} catch (err) {
// Consume the error response body to prevent resource leaks (see #3173)
if (err instanceof PostHogFetchHttpError) {
await err.response.text().catch(() => {})
}
this._events.emit('error', err)
}
}
Expand Down Expand Up @@ -1139,8 +1147,17 @@ export abstract class PostHogCoreStateless {
}

try {
await this.fetchWithRetry(url, fetchOptions, retryOptions)
const res = await this.fetchWithRetry(url, fetchOptions, retryOptions)
// Consume the response body to prevent resource leaks in runtimes like
// Cloudflare Workers that require the body to be read before the handler completes.
// See: https://github.com/PostHog/posthog-js/issues/3173
await res.text().catch(() => {})
} catch (err) {
// Consume the error response body to prevent resource leaks (see #3173)
if (err instanceof PostHogFetchHttpError) {
await err.response.text().catch(() => {})
}

if (isPostHogFetchContentTooLargeError(err) && batchMessages.length > 1) {
// if we get a 413 error, we want to reduce the batch size and try again
this.maxBatchSize = Math.max(1, Math.floor(batchMessages.length / 2))
Expand Down