chore: remove failure emoji from slack thread on successful release retry#3283
Merged
marandaneto merged 1 commit intomainfrom Mar 25, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📝 No Changeset FoundThis PR doesn't include a changeset. A changeset (and the release label) is required to release a new version. How to add a changesetRun this command and follow the prompts: pnpm changesetRemember: Never use |
Member
Author
|
depends on PostHog/.github#35 |
Contributor
|
Reviews (1): Last reviewed commit: "chore: remove failure emoji from slack t..." | Re-trigger Greptile |
Contributor
Contributor
|
Size Change: 0 B Total Size: 6.56 MB ℹ️ View Unchanged
|
dustinbyrne
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When the release workflow fails, a ❌ (
x) emoji reaction is added to the Slack notification thread. If the workflow is retried and succeeds, a 🚀 (rocket) emoji is added but the ❌ is never removed — leaving the thread with both emojis, which is confusing.Changes
Pass
remove_emoji_reaction: 'x'to theslack-thread-replyaction in thenotify-releasedjob so that the failure emoji is removed before the success emoji is added.Libraries affected
Checklist