fix: resolve flaky playwright tests with event-driven waits#3310
Merged
marandaneto merged 5 commits intomainfrom Apr 1, 2026
Merged
fix: resolve flaky playwright tests with event-driven waits#3310marandaneto merged 5 commits intomainfrom
marandaneto merged 5 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📝 No Changeset FoundThis PR doesn't include a changeset. A changeset (and the release label) is required to release a new version. How to add a changesetRun this command and follow the prompts: pnpm changesetRemember: Never use |
Contributor
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
Contributor
|
Size Change: 0 B Total Size: 6.65 MB ℹ️ View Unchanged
|
… assertions - retry-queue 'retries and stops after success': set 90s test timeout (exponential backoff can take 40s+ worst case), use successSeen flag instead of counting requests, and verify stability with a simple toPass poll (no inner waitForTimeout) - mouse move tests: relax allPositions to >= 1 since rrweb can merge all moves into a single position entry under CI load
dustinbyrne
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Several Playwright tests were flaky in CI due to timing races caused by fixed
waitForTimeoutcalls and test timeouts too short for exponential backoff. The affected tests:Changes
All fixes replace fixed timeouts with event-driven waits and relax brittle assertions:
retry-queue.spec.ts
successSeenflag set in the route handler instead of polling request count — directly waits for the event we care about. Verify stability after success with a simpletoPasspoll (no innerwaitForTimeout).session-recording.spec.ts & lazy-session-recording.spec.ts
allPositions.lengthassertion from>= 2to>= 1, and only assert the last position is further right when multiple positions are captured.surveys/core-display-logic.spec.ts
lastSeenSurveyDateto localStorage asynchronously after rendering the survey. Usedpage.waitForFunction()to wait for the value to be written in the browser context before reading it.Release info Sub-libraries affected
Libraries affected
None — test-only changes.
Checklist