fix: send $groupidentify for new groups even without properties (core SDK)#3320
Merged
dustinbyrne merged 1 commit intomainfrom Apr 1, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Reviews (1): Last reviewed commit: "fix: send $groupidentify for new groups ..." | Re-trigger Greptile |
Contributor
Contributor
|
Size Change: +292 B (0%) Total Size: 6.65 MB
ℹ️ View Unchanged
|
marandaneto
approved these changes
Apr 1, 2026
dustinbyrne
deleted the
fix/core-group-always-send-groupidentify-for-new-groups
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Follow-up to #3319 (browser SDK fix). The same bug exists in the core SDK (
@posthog/core), which is used by React Native.Calling
posthog.group("company", "company_id")without properties does not send a$groupidentifyevent, meaning the group type and group are never created server-side. This is inconsistent with iOS, Android, Unity, and Flutter SDKs which all always send$groupidentify.Changes
packages/core/src/posthog-core.tsgroup()now checks whether the group key is new before callinggroups(), and sends$groupidentifyviagroupIdentify()when the group is new/changed — even without properties.packages/core/src/__tests__/posthog.groups.spec.ts$groupidentify$groupidentify$groupidentifywith$group_setpackages/core/src/__tests__/posthog.featureflags.spec.tsandposthog.featureflags.v1.spec.ts$groupidentifyfetch call.Release info Sub-libraries affected
Libraries affected
Checklist
If releasing new changes
pnpm changesetto generate a changeset file