Variants are case sensitive

Author: haacked

posthog/feature_flags.py

@@ -189,8 +189,8 @@ def matches_dependency_value(expected_value, actual_value):
             # Any variant matches boolean true
             return expected_value
         elif isinstance(expected_value, str):
-            # String comparison (case-insensitive to match C# StringComparison.OrdinalIgnoreCase)
-            return actual_value.lower() == expected_value.lower()
+            # variants are case-sensitive, hence our comparison is too
+            return actual_value == expected_value
         else:
             return False
 

posthog/test/test_feature_flags.py

@@ -2074,10 +2074,11 @@ def test_matches_dependency_value(self):
         """Test the matches_dependency_value function logic"""
         from posthog.feature_flags import matches_dependency_value
 
-        # String variant matches string exactly (case-insensitive)
+        # String variant matches string exactly (case-sensitive)
         self.assertTrue(matches_dependency_value("control", "control"))
-        self.assertTrue(matches_dependency_value("control", "Control"))
-        self.assertTrue(matches_dependency_value("control", "CONTROL"))
+        self.assertTrue(matches_dependency_value("Control", "Control"))
+        self.assertFalse(matches_dependency_value("control", "Control"))
+        self.assertFalse(matches_dependency_value("Control", "CONTROL"))
         self.assertFalse(matches_dependency_value("control", "test"))
 
         # String variant matches boolean true (any variant is truthy)