Merged
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
PR Summary
This PR adds automatic retry functionality for connection errors in the PostHog Python client, implementing basic retry logic for network-related failures.
- Added HTTPAdapter with
max_retries=2in/posthog/request.pyto handle failed DNS lookups, socket connections and timeouts - Mounted adapter specifically to HTTPS protocol via
_session.mount('https://', adapter) - Version bumped to 3.13.0 in
/posthog/version.pyto reflect new feature addition - Clear documentation added in CHANGELOG.md about the automatic retry capability
3 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
posthog/request.py
Outdated
Comment on lines
15
to
17
| adapter = HTTPAdapter(max_retries=2) | ||
| _session = requests.sessions.Session() | ||
| _session.mount('https://', adapter) |
Contributor
There was a problem hiding this comment.
style: Consider mounting the adapter for both 'http://' and 'https://' protocols to handle all potential connection types.
frankh
force-pushed
the
frank/retry-connection-errors
branch
from
0e87219 to
71bc7ff
Compare
daibhin
approved these changes
Feb 12, 2025
frankh
force-pushed
the
frank/retry-connection-errors
branch
2 times, most recently
from
275d648 to
9734403
Compare
from the docs for max_retries: this applies only to failed DNS lookups, socket connections and connection timeouts
frankh
force-pushed
the
frank/retry-connection-errors
branch
from
9734403 to
6b9bdc7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
from the docs for max_retries: this applies only to failed DNS lookups,
socket connections and connection timeouts