Skip to content

Conversation

@pauldambra
Copy link
Member

see https://github.com/PostHog/posthog-python/actions/runs/15468256593/job/43545576349

cursor and claude say this will fix it

also copies a README improvement from #211

@pauldambra pauldambra requested a review from a team June 5, 2025 13:47
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Updated package setup configurations to fix release action failures and improve package metadata consistency.

  • Added explicit license_files=['LICENSE'] in both setup files to ensure proper license distribution
  • Set python_requires='>=3.9' to formally declare minimum Python version requirement
  • Fixed Flake8 E402 warnings by adding noqa comments for version imports
  • Enhanced README with visual improvements and current community metrics
  • Improved long description readability in setup files with proper line breaks

3 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile

## Questions?

### [Join our Slack community.](https://join.slack.com/t/posthogusers/shared_invite/enQtOTY0MzU5NjAwMDY3LTc2MWQ0OTZlNjhkODk3ZDI3NDVjMDE1YjgxY2I4ZjI4MzJhZmVmNjJkN2NmMGJmMzc2N2U3Yjc3ZjI5NGFlZDQ)
Updated are released using GitHub Actions: after bumping `version.py` in `master` and adding to `CHANGELOG.md`, go to [our release workflow's page](https://github.com/PostHog/posthog-python/actions/workflows/release.yaml) and dispatch it manually, using workflow from `master`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

syntax: Typo: 'Updated are released' should be 'Updates are released'

Suggested change
Updated are released using GitHub Actions: after bumping `version.py` in `master` and adding to `CHANGELOG.md`, go to [our release workflow's page](https://github.com/PostHog/posthog-python/actions/workflows/release.yaml) and dispatch it manually, using workflow from `master`.
Updates are released using GitHub Actions: after bumping `version.py` in `master` and adding to `CHANGELOG.md`, go to [our release workflow's page](https://github.com/PostHog/posthog-python/actions/workflows/release.yaml) and dispatch it manually, using workflow from `master`.

@pauldambra pauldambra merged commit 7ab2080 into master Jun 5, 2025
6 checks passed
@pauldambra pauldambra deleted the chore/fix-release branch June 5, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants