feat: add before_send callback #249
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Adds a before_send callback feature to the Python SDK, enabling event modification or filtering before transmission to PostHog, aligning with existing JS and Ruby SDK implementations.
- Implements new
BeforeSendCallbacktype intypes.pyallowing events to be modified or dropped with type-safe handling - Adds robust error handling in
client.pyto maintain original event data if callback fails - Includes comprehensive documentation in
BEFORE_SEND.mdwith examples for PII filtering and event transformation - Adds thorough test coverage in
test_client.pyvalidating event modification, dropping, and error cases
4 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
pauldambra
force-pushed
the
feat/before_send
branch
from
09a399e to
b8eeb9c
Compare
| exception_autocapture_integrations=None, | ||
| project_root=None, | ||
| privacy_mode=False, | ||
| before_send=None, |
There was a problem hiding this comment.
interestingly adding a type to this parameter kicked mypy into being strict about the other parameters and we got ~14 errors
i'm going to punt on that for now since this PR doesn't introduce them
robbie-c
left a comment
robbie-c
left a comment
There was a problem hiding this comment.
Aren't you on vacation today?
contributing to open source while you're on vacation is totally standard, right? (will probably cancel day off since I've ended up working 🤣) |
we've got this in posthog-js and posthog-ruby
let's add it here
ultimate power to edit/drop/fix events as you see fit