Skip to content

Conversation

@pauldambra
Copy link
Member

hard to test this locally.

we got

rm -rf dist/*
python setup.py sdist bdist_wheel
/opt/hostedtoolcache/Python/3.11.11/x64/lib/python3.11/site-packages/setuptools/config/pyprojecttoml.py:108: _BetaConfiguration: Support for `[tool.setuptools]` in `pyproject.toml` is still *beta*.
  warnings.warn(msg, _BetaConfiguration)
usage: setup.py [global_opts] cmd1 [cmd1_opts] [cmd2 [cmd2_opts] ...]
   or: setup.py --help [cmd1 cmd2 ...]
   or: setup.py --help-commands
   or: setup.py cmd --help

error: invalid command 'bdist_wheel'

but we're doing

      - name: Prepare for building release
        run: uv sync --extra build

most likely gh isn't using the env so explicitly use uv run

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Modified the release workflow to explicitly use uv run for executing release commands, fixing a build error where bdist_wheel command wasn't found due to environment isolation issues.

  • Changed release command execution in .github/workflows/release.yaml to use uv run make release instead of direct make release calls, ensuring proper environment context

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@pauldambra pauldambra requested a review from a team June 9, 2025 10:03
@pauldambra pauldambra enabled auto-merge (squash) June 9, 2025 10:08
@pauldambra pauldambra merged commit a2105f6 into master Jun 9, 2025
6 checks passed
@pauldambra pauldambra deleted the chore/ci/use-uv-env branch June 9, 2025 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants