-
Notifications
You must be signed in to change notification settings - Fork 53
remove 'import posthog' #255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -39,7 +39,7 @@ def new_context(fresh=False): | |
| raise ValueError("Something went wrong") | ||
|
|
||
| """ | ||
| import posthog | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. would be cool if we can have ruff forbid this in future
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Agreed. ChatGPT is down right now and I'm having trouble googling for the right rule. Will double back |
||
| from posthog import capture_exception | ||
|
|
||
| current_tags = _get_current_context().copy() | ||
| current_stack = _context_stack.get() | ||
|
|
@@ -49,7 +49,7 @@ def new_context(fresh=False): | |
| try: | ||
| yield | ||
| except Exception as e: | ||
| posthog.capture_exception(e) | ||
| capture_exception(e) | ||
| raise | ||
| finally: | ||
| _context_stack.reset(token) | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,3 @@ | ||
| import hashlib | ||
| import time | ||
| import unittest | ||
| from datetime import datetime | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| VERSION = "4.6.1" | ||
| VERSION = "4.6.2" | ||
|
|
||
| if __name__ == "__main__": | ||
| print(VERSION, end="") # noqa: T201 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: Removing and recreating 'posthog' directory between operations could lead to issues if twine upload fails. Consider moving directory operations after successful upload.