fix(err): add synthetic exception, use it to prevent attributeerrors #260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverb123
changed the title
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
PR Summary
Introduces a new SyntheticException wrapper class to standardize exception handling and prevent AttributeErrors when working with raw exception tuples.
- Added
posthog/synthetic_exception.pyto provide a consistent interface for exception data with proper attribute handling - Modified
exception_utils.pyto support synthetic exceptions in exception info processing - Updated exception handlers in
exception_capture.pyto wrap raw exception tuples withSyntheticException - Ensures proper handling of
__traceback__attribute across all exception scenarios
3 files reviewed, 2 comments
Edit PR Review Bot Settings | Greptile
| @@ -0,0 +1,14 @@ | |||
| class SyntheticException(BaseException): | |||
Contributor
There was a problem hiding this comment.
style: Consider inheriting from Exception instead of BaseException. BaseException is typically reserved for system exits and keyboard interrupts.
Suggested change
| class SyntheticException(BaseException): | |
| class SyntheticException(Exception): |
Comment on lines
+11
to
+14
| if exc_value: | ||
| super().__init__(str(exc_value)) | ||
| else: | ||
| super().__init__(f"{exc_type.__name__}") |
Contributor
There was a problem hiding this comment.
style: Consider using a more descriptive message format that includes both type and value when available: f"{exc_type.name}: {exc_value if exc_value else ''}"
Contributor
Author
|
Closed in favour of #261 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.