chore: ensure session_id context works with page method #269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lricoy
commented
Jun 20, 2025
| self.assertEqual(msg["uuid"], "new-uuid") | ||
| self.assertEqual(msg["distinct_id"], "distinct_id") | ||
|
|
||
| @parameterized.expand( |
Member
Author
There was a problem hiding this comment.
Those were for finding my way around the SDK, but I think they're fine to keep. I can remove them otherwise
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
PR Summary
Added support for session ID preservation in the PostHog Python client's page() function to maintain consistent session tracking between frontend and backend events.
- Added session ID handling in
page()function to match behavior ofidentify()andcapture()methods - Modified context handling to ensure automatic inclusion of session IDs when available in global context
- Added comprehensive test suite covering session ID persistence across different event capture scenarios
- Improved cross-platform session tracking by standardizing session ID handling between frontend and backend events
2 files reviewed, no comments
Edit PR Review Bot Settings | Greptile
lricoy
requested review from
a team,
haacked,
jabahamondes,
oliverb123 and
robbie-c
and removed request for
a team
lricoy
changed the title
lricoy
requested review from
rafaeelaudibert
and removed request for
jabahamondes and
robbie-c
rafaeelaudibert
approved these changes
Jun 20, 2025
Member
rafaeelaudibert
left a comment
rafaeelaudibert
left a comment
There was a problem hiding this comment.
That makes a lot of sense to me, LGTM :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am investigating some tickets (e.g, https://posthoghelp.zendesk.com/agent/tickets/32213) that send events on both frontend and backend, and wish to keep the sessionId in sync.
The changes here build upon #264 (thanks @oliverb123, great work!) to ensure we can also keep the session_id in context for the
pageutility function, as well as some redundant tests to verify that we're passing it on to other methods.