fix: add middleware setting for custom client #281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
PR Summary
Added support for custom PostHog client instances in Django middleware through a new POSTHOG_MW_CLIENT setting, enhancing flexibility for users who prefer instance-based client management over module-level methods.
- Added setting in
posthog/integrations/django.pyto allow configurable client instance in middleware - Updated version from 6.0.3 to 6.0.4 in
posthog/version.pyfor this backward-compatible fix - Added documentation in
CHANGELOG.mdto reflect the new middleware client customization feature
3 files reviewed, 2 comments
Edit PR Review Bot Settings | Greptile
posthog/integrations/django.py
Outdated
| The context will also auto-capture exceptions and send them to PostHog, unless you disable it by setting | ||
| `POSTHOG_MW_CAPTURE_EXCEPTIONS` to `False` in your Django settings. | ||
| `POSTHOG_MW_CAPTURE_EXCEPTIONS` to `False` in your Django settings. The exceptions are captured using the | ||
| global client, unless the setting `POSTHOG_MW_CLIENT` is set to a custom client instant. |
Contributor
There was a problem hiding this comment.
syntax: 'instant' should be 'instance'
Suggested change
| global client, unless the setting `POSTHOG_MW_CLIENT` is set to a custom client instant. | |
| global client, unless the setting `POSTHOG_MW_CLIENT` is set to a custom client instance. |
hpouillot
approved these changes
Jul 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many people construct a client instance, rather than using the module methods, and need a way to use that initialised client in the django middleware