fix: Ignore new flag filter type in local evaluation
#285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
PR Summary
Added graceful handling of flag dependencies in local feature flag evaluation by skipping unsupported 'flag' type filters to prevent serialization errors.
- Modified local evaluation logic in
posthog/feature_flags.pyto handle 'flag' type filters by skipping them with a warning - Added test coverage in
posthog/test/test_feature_flags.pyto verify proper handling of flag dependencies - Enhanced error handling to prevent serialization failures when encountering flag-based conditions
- Maintains backward compatibility by continuing to evaluate other conditions when flag dependencies are encountered
2 files reviewed, no comments
Edit PR Review Bot Settings | Greptile
dmarticus
approved these changes
Jul 11, 2025
haacked
force-pushed
the
haacked/ignore-flag-dependencies
branch
from
1a38148 to
5f97812
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for the new "flag" filter type to prevent serialization errors during local feature flag evaluation. Flag dependencies are not yet implemented in local evaluation, so these conditions are skipped to allow other conditions to be evaluated properly.