fix: must clean elements from maps on remove from DOM#124
Merged
pauldambra merged 1 commit intomainfrom Jan 29, 2026
Merged
Conversation
pauldambra
requested review from
a team,
TueHaulund,
fasyy612 and
ksvat
and removed request for
a team
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
TueHaulund
approved these changes
Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when watching detached elements while the posthog app is running
i see detached elements accruing when react components unmount
i believe one of the sources is a strong reference to the element here
so let's clean these maps when removing elements