Skip to content

fix: correctly cache expensive operation #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pauldambra merged 3 commits into from
Jan 23, 2025
Merged

fix: correctly cache expensive operation #22

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f75c1af
fix: correctly cache expensive operation
pauldambra Jan 23, 2025
57dcdd6
goddamn format
pauldambra Jan 23, 2025
d4bbb60
Merge branch 'main' into fix/pd/correctly-cache
pauldambra Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/rrweb-snapshot/src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -479,6 +479,7 @@ export function splitCssText(
// eslint-disable-next-line @typescript-eslint/no-non-null-assertion
return splitCache.get(cssText)!;
}
const og = cssText;
const childNodes = Array.from(style.childNodes);
const splits: string[] = [];
let iterLimit = 0;
Expand Down Expand Up @@ -553,7 +554,7 @@ export function splitCssText(
}
}
splits.push(cssText); // either the full thing if no splits were found, or the last split
splitCache.set(cssText, splits);
splitCache.set(og, splits);
return splits;
}

Expand Down
Loading