Skip to content

fix: much better zone detection#24

Merged
pauldambra merged 4 commits intomainfrom
fix/much-better-zone-detection
Jan 24, 2025
Merged

fix: much better zone detection#24
pauldambra merged 4 commits intomainfrom
fix/much-better-zone-detection

Conversation

@pauldambra
Copy link
Member

this is how Angular was detected in rrweb v1

in tests with a log when the observer fires, we don't see that log with current code and do see the log with this

@pauldambra
Copy link
Member Author

should contribute this back if we see it fix things in prod

@github-actions
Copy link
Contributor

github-actions bot commented Jan 23, 2025

Size Change: +11.8 kB (+0.11%)

Total Size: 10.3 MB

Filename Size Change
packages/all/dist/rrweb-all.cjs 556 kB +706 B (+0.13%)
packages/all/dist/rrweb-all.js 556 kB +706 B (+0.13%)
packages/all/dist/rrweb-all.umd.cjs 559 kB +706 B (+0.13%)
packages/all/dist/rrweb-all.umd.min.cjs 272 kB +292 B (+0.11%)
packages/record/dist/rrweb-record.cjs 378 kB +700 B (+0.19%)
packages/record/dist/rrweb-record.js 378 kB +700 B (+0.19%)
packages/record/dist/rrweb-record.umd.cjs 380 kB +700 B (+0.18%)
packages/record/dist/rrweb-record.umd.min.cjs 183 kB +292 B (+0.16%)
packages/replay/dist/rrweb-replay.cjs 388 kB +350 B (+0.09%)
packages/replay/dist/rrweb-replay.js 388 kB +350 B (+0.09%)
packages/replay/dist/rrweb-replay.umd.cjs 392 kB +350 B (+0.09%)
packages/replay/dist/rrweb-replay.umd.min.cjs 194 kB +146 B (+0.08%)
packages/rrweb-player/dist/rrweb-player.cjs 460 kB +353 B (+0.08%)
packages/rrweb-player/dist/rrweb-player.js 460 kB +353 B (+0.08%)
packages/rrweb-player/dist/rrweb-player.umd.cjs 463 kB +353 B (+0.08%)
packages/rrweb-player/dist/rrweb-player.umd.min.cjs 223 kB +146 B (+0.07%)
packages/rrweb-snapshot/dist/rrweb-snapshot.cjs 164 kB +346 B (+0.21%)
packages/rrweb-snapshot/dist/rrweb-snapshot.js 163 kB +346 B (+0.21%)
packages/rrweb-snapshot/dist/rrweb-snapshot.umd.cjs 166 kB +346 B (+0.21%)
packages/rrweb-snapshot/dist/rrweb-snapshot.umd.min.cjs 81.7 kB +146 B (+0.18%)
packages/rrweb/dist/rrweb.cjs 539 kB +700 B (+0.13%)
packages/rrweb/dist/rrweb.js 538 kB +700 B (+0.13%)
packages/rrweb/dist/rrweb.umd.cjs 540 kB +700 B (+0.13%)
packages/rrweb/dist/rrweb.umd.min.cjs 262 kB +292 B (+0.11%)
packages/utils/dist/rrweb-utils.cjs 6.37 kB +293 B (+4.82%) 🔍
packages/utils/dist/rrweb-utils.js 5.9 kB +322 B (+5.77%) 🔍
packages/utils/dist/rrweb-utils.umd.cjs 7.4 kB +293 B (+4.13%)
packages/utils/dist/rrweb-utils.umd.min.cjs 4.11 kB +115 B (+2.88%)
ℹ️ View Unchanged
Filename Size
packages/packer/dist/base-B40z8PPs.cjs 18.3 kB
packages/packer/dist/base-B40z8PPs.umd.cjs 19.4 kB
packages/packer/dist/base-B40z8PPs.umd.min.cjs 10.1 kB
packages/packer/dist/base-BrE4jft0.js 18.2 kB
packages/packer/dist/pack.cjs 347 B
packages/packer/dist/pack.js 285 B
packages/packer/dist/pack.umd.cjs 2.25 kB
packages/packer/dist/pack.umd.min.cjs 1.73 kB
packages/packer/dist/packer.cjs 257 B
packages/packer/dist/packer.js 136 B
packages/packer/dist/packer.umd.cjs 1.28 kB
packages/packer/dist/packer.umd.min.cjs 1.25 kB
packages/packer/dist/unpack.cjs 769 B
packages/packer/dist/unpack.js 702 B
packages/packer/dist/unpack.umd.cjs 1.79 kB
packages/packer/dist/unpack.umd.min.cjs 1.57 kB
packages/plugins/rrweb-plugin-canvas-webrtc-record/dist/rrweb-plugin-canvas-webrtc-record.cjs 37.6 kB
packages/plugins/rrweb-plugin-canvas-webrtc-record/dist/rrweb-plugin-canvas-webrtc-record.js 37.5 kB
packages/plugins/rrweb-plugin-canvas-webrtc-record/dist/rrweb-plugin-canvas-webrtc-record.umd.cjs 38.7 kB
packages/plugins/rrweb-plugin-canvas-webrtc-record/dist/rrweb-plugin-canvas-webrtc-record.umd.min.cjs 22.9 kB
packages/plugins/rrweb-plugin-canvas-webrtc-replay/dist/rrweb-plugin-canvas-webrtc-replay.cjs 34.3 kB
packages/plugins/rrweb-plugin-canvas-webrtc-replay/dist/rrweb-plugin-canvas-webrtc-replay.js 34.2 kB
packages/plugins/rrweb-plugin-canvas-webrtc-replay/dist/rrweb-plugin-canvas-webrtc-replay.umd.cjs 35.4 kB
packages/plugins/rrweb-plugin-canvas-webrtc-replay/dist/rrweb-plugin-canvas-webrtc-replay.umd.min.cjs 21.2 kB
packages/plugins/rrweb-plugin-console-record/dist/rrweb-plugin-console-record.cjs 15 kB
packages/plugins/rrweb-plugin-console-record/dist/rrweb-plugin-console-record.js 14.9 kB
packages/plugins/rrweb-plugin-console-record/dist/rrweb-plugin-console-record.umd.cjs 16.1 kB
packages/plugins/rrweb-plugin-console-record/dist/rrweb-plugin-console-record.umd.min.cjs 8.03 kB
packages/plugins/rrweb-plugin-console-replay/dist/rrweb-plugin-console-replay.cjs 5.01 kB
packages/plugins/rrweb-plugin-console-replay/dist/rrweb-plugin-console-replay.js 4.9 kB
packages/plugins/rrweb-plugin-console-replay/dist/rrweb-plugin-console-replay.umd.cjs 6.07 kB
packages/plugins/rrweb-plugin-console-replay/dist/rrweb-plugin-console-replay.umd.min.cjs 3.27 kB
packages/plugins/rrweb-plugin-sequential-id-record/dist/rrweb-plugin-sequential-id-record.cjs 681 B
packages/plugins/rrweb-plugin-sequential-id-record/dist/rrweb-plugin-sequential-id-record.js 548 B
packages/plugins/rrweb-plugin-sequential-id-record/dist/rrweb-plugin-sequential-id-record.umd.cjs 1.76 kB
packages/plugins/rrweb-plugin-sequential-id-record/dist/rrweb-plugin-sequential-id-record.umd.min.cjs 1.47 kB
packages/plugins/rrweb-plugin-sequential-id-replay/dist/rrweb-plugin-sequential-id-replay.cjs 933 B
packages/plugins/rrweb-plugin-sequential-id-replay/dist/rrweb-plugin-sequential-id-replay.js 820 B
packages/plugins/rrweb-plugin-sequential-id-replay/dist/rrweb-plugin-sequential-id-replay.umd.cjs 2.01 kB
packages/plugins/rrweb-plugin-sequential-id-replay/dist/rrweb-plugin-sequential-id-replay.umd.min.cjs 1.61 kB
packages/replay/dist/style.css 2.45 kB
packages/replay/dist/style.min.css 1.97 kB
packages/rrdom-nodejs/dist/rrdom-nodejs.cjs 132 kB
packages/rrdom-nodejs/dist/rrdom-nodejs.js 131 kB
packages/rrdom-nodejs/dist/rrdom-nodejs.umd.cjs 134 kB
packages/rrdom-nodejs/dist/rrdom-nodejs.umd.min.cjs 66.9 kB
packages/rrdom/dist/rrdom.cjs 150 kB
packages/rrdom/dist/rrdom.js 149 kB
packages/rrdom/dist/rrdom.umd.cjs 152 kB
packages/rrdom/dist/rrdom.umd.min.cjs 74.1 kB
packages/rrweb-player/dist/events.js 159 kB
packages/rrweb-player/dist/global.css 240 B
packages/rrweb-player/dist/style.css 5.57 kB
packages/rrweb-player/dist/style.min.css 5 kB
packages/rrweb/dist/style.css 2.45 kB
packages/rrweb/dist/style.min.css 1.97 kB
packages/types/dist/rrweb-types.cjs 5.64 kB
packages/types/dist/rrweb-types.js 5.38 kB
packages/types/dist/rrweb-types.umd.cjs 6.66 kB
packages/types/dist/rrweb-types.umd.min.cjs 3.42 kB

compressed-size-action

@pauldambra pauldambra merged commit eaec896 into main Jan 24, 2025
7 checks passed
@pauldambra pauldambra deleted the fix/much-better-zone-detection branch January 24, 2025 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant