fix: react key warning in CodeBlock #14070
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When you have two tabs and they are both set to the same language switching breaks because the key to the element was set to the lang and was repeating itself Additionally - the useEffect was resetting the state unnecessarily
|
@yoavf is attempting to deploy a commit to the PostHog Team on Vercel. A member of the Team first needs to authorize it. |
yoavf
changed the title
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
sarahxsanders
approved these changes
Dec 12, 2025
Contributor
sarahxsanders
left a comment
sarahxsanders
left a comment
There was a problem hiding this comment.
approved! the fix looks good. I tested and verified on posthog.com/docs/api/capture, it has lots of code snips :) ran it locally before/after the change and the warning is gone from the console
Contributor
|
@smallbrownbike This look good to you? |
smallbrownbike
approved these changes
Dec 12, 2025
Collaborator
smallbrownbike
left a comment
smallbrownbike
left a comment
There was a problem hiding this comment.
Looks good, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Prevents the following warning on the LLM analytics docs:
(This PR also contained the fix for the non-working tabs, but that was done in #14075 - so updated to only fix the above warning)