fix: monaco editor upgrade #42232
Merged
fix: monaco editor upgrade #42232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wiz Scan Summary
|
| Scanner | Findings |
|---|---|
 |
20    |
 |
- |
 |
- |
 |
- |
 |
- |
| Total | 20 |
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension.
Gilbert09
approved these changes
Nov 27, 2025
Copilot finished reviewing on behalf of
pauldambra
November 27, 2025 17:09
Contributor
There was a problem hiding this comment.
Pull request overview
This PR upgrades the monaco-editor package from version 0.49.0 to 0.55.1 to maintain compatibility with the latest editor features. The description confirms that the editor still runs correctly after the upgrade.
Key Changes:
- Upgraded monaco-editor dependency from ^0.49.0 to ^0.55.1
- Updated lockfile to reflect new transitive dependencies ([email protected] and [email protected]) now required by monaco-editor
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| frontend/package.json | Updated monaco-editor version specifier from ^0.49.0 to ^0.55.1 |
| pnpm-lock.yaml | Resolved new monaco-editor version and its transitive dependencies (dompurify, marked) across the dependency graph |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
pauldambra
force-pushed
the
fix/update-mon
branch
2 times, most recently
from
709740a to
2e7dfe6
Compare
Contributor
|
Size Change: 0 B Total Size: 3.41 MB ℹ️ View Unchanged
|
pauldambra
force-pushed
the
fix/update-mon
branch
4 times, most recently
from
269f5b3 to
c8c18eb
Compare
pauldambra
commented
Nov 28, 2025
playwright/e2e/sql-editor.spec.ts
Outdated
| await expect(page.locator('[data-attr=sql-editor-output-pane-empty-state]')).toBeVisible() | ||
| await page.locator('[data-attr=hogql-query-editor]').click() | ||
| await page.locator('textarea[aria-roledescription="editor"]').fill('SELECT 1') | ||
| await page.locator('[aria-roledescription="editor"]').fill('SELECT 1') |
Member
Author
There was a problem hiding this comment.
@Gilbert09 just in case you all are using actions with this textarea selector... it's no longer a textarea in the latest version :)
pauldambra
force-pushed
the
fix/update-mon
branch
from
c8c18eb to
9eeae3d
Compare
� Conflicts: � frontend/package.json � pnpm-lock.yaml
pauldambra
force-pushed
the
fix/update-mon
branch
from
9eeae3d to
58a9d42
Compare
pauldambra
added a commit
that referenced
this pull request
Nov 28, 2025
This reverts commit 0b1c02e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i can still run the editor