feat(customers): Filter insight by person in PersonFeedCanvas

[arthurdedeus]

Problem

When viewing a person's feed in a notebook, we need to automatically apply filters to show only events related to that person. Currently, this filtering is not applied automatically, requiring users to manually set up filters.

Changes

• Added canvasFiltersOverride to the Notebook component and notebookLogic to allow passing filters from parent components
• Modified NotebookNodeQuery to apply canvas filters to queries when they are first created
• Added person ID filter in PersonFeedCanvas to automatically filter events by the current person
• Added tracking for whether default filters have been applied to prevent duplicate application
• Enhanced query type checking with utility functions like isDataTableNode, isEventsQuery, etc.

How did you test this code?

• Tested creating a new insight for each kind in a person's feed canvas and verified that the current person filters were correctly applied
• Verified that filters are correctly applied to different query types (DataTableNode, InsightVizNode)
• Confirmed that filters are only applied once to prevent duplicate filters
• Tested insights in normal canvas to ensure it still works when no overrides are passed down

Changelog: Yes

[arthurdedeus]

• feat(customers): Filter insight by group in GroupFeedCanvas #42250
• feat(customers): Filter insight by person in PersonFeedCanvas #42247 👈 (View in Graphite)
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

Size Change: 0 B

Total Size: 3.41 MB

ℹ️ View Unchanged

Filename	Size
frontend/dist/toolbar.js	3.41 MB

_{compressed-size-action}

[greptile-apps]

_{4 files reviewed, 3 comments}

_{Edit Code Review Agent Settings | Greptile}

[greptile-apps]

logic: updateAttributes is called inside useMemo, which violates React rules - useMemo should be pure and not have side effects. This can cause unexpected behavior and infinite render loops.

Move the filter application logic to a useEffect hook instead:

useEffect(() => {
    if (
        isInsightVizNode(modifiedQuery) &&
        !isHogQLQuery(modifiedQuery.source) &&
        !isActorsQuery(modifiedQuery.source) &&
        !isDefaultFilterApplied &&
        canvasFiltersOverride
    ) {
        updateAttributes({ ...attributes, isDefaultFilterApplied: true })
    }
    
    if (isDataTableNode(modifiedQuery) && isEventsQuery(modifiedQuery.source) && !isDefaultFilterApplied && canvasFiltersOverride) {
        updateAttributes({ ...attributes, isDefaultFilterApplied: true })
    }
}, [isDefaultFilterApplied, canvasFiltersOverride, query.kind, query.source?.kind])

Prompt To Fix With AI

This is a comment left during a code review.
Path: frontend/src/scenes/notebooks/Nodes/NotebookNodeQuery.tsx
Line: 184:197

Comment:
**logic:** `updateAttributes` is called inside `useMemo`, which violates React rules - `useMemo` should be pure and not have side effects. This can cause unexpected behavior and infinite render loops.

Move the filter application logic to a `useEffect` hook instead:

```
useEffect(() => {
    if (
        isInsightVizNode(modifiedQuery) &&
        !isHogQLQuery(modifiedQuery.source) &&
        !isActorsQuery(modifiedQuery.source) &&
        !isDefaultFilterApplied &&
        canvasFiltersOverride
    ) {
        updateAttributes({ ...attributes, isDefaultFilterApplied: true })
    }
    
    if (isDataTableNode(modifiedQuery) && isEventsQuery(modifiedQuery.source) && !isDefaultFilterApplied && canvasFiltersOverride) {
        updateAttributes({ ...attributes, isDefaultFilterApplied: true })
    }
}, [isDefaultFilterApplied, canvasFiltersOverride, query.kind, query.source?.kind])
```

How can I resolve this? If you propose a fix, please make it concise.

[arthurdedeus]

this specific case is safe, as we're updating isDefaultFilterApplied, which is not in the dependency array.

[daibhin]

Left a comment on the prop in Notebooks. I'm going to tag the PA team because they own the query node (I'm trying to keep my involvement with notebooks to the framework level)