-
Notifications
You must be signed in to change notification settings - Fork 10
feat: react router agent #215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| integration: Integration.reactRouter, | ||
| docsUrl: 'https://posthog.com/docs/libraries/react', | ||
| unsupportedVersionDocsUrl: 'https://posthog.com/docs/libraries/react', | ||
| abortMessage: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, we can start to see the parts that are generalizable. We can probably live without a per-framework abort message. It's probably the same message each time, with the docs URL piped in for that framework
|
|
||
| ui: { | ||
| welcomeMessage: 'PostHog React Router wizard (agent-powered)', | ||
| spinnerMessage: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably can share these between frameworks too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True
| import * as path from 'node:path'; | ||
| import * as semver from 'semver'; | ||
|
|
||
| export enum ReactRouterMode { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, all my homies love enums
daniloc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks right to me, can't wait to get it into testing. Couple things we can clean up for future integrations if you're up for it.
how was the DX of getting all this slotted in?
Adds react router. Uses code in this examples PR and docs from this PR