chore: Update Next integration strategy #50
Conversation
joshsny
left a comment
joshsny
left a comment
There was a problem hiding this comment.
Love it - left a couple small comments to address - looking forward getting this improvement shipped!
|
|
||
| When we make improvements to this process, these are available instantly to all users of the wizard, no training delays or other ambiguity. | ||
|
|
||
| ## Testing locally |
There was a problem hiding this comment.
You can also use pnpm try if you don't want to rebuild each time :)
There was a problem hiding this comment.
Oh get this: doesn't work if we need to detect a version as in instrumentation-client. Gotta actually build and run it from the directory
There was a problem hiding this comment.
Unless I'm holding it wrong?
There was a problem hiding this comment.
sorry that was very poorly documented, you can do pnpm try --install-dir=e2e-tests/test-applications/nextjs-app-router-test-app for running in an app and that should work without a build :)
There was a problem hiding this comment.
Okay that works!
if I drag and drop a folder into the CLI, as in
pnpm try --install-dir='/Users/daniloc/Documents/Dev/wizard/e2e-tests/test-applications/nextjs-app-router-test-app'
I get an error. an issue escaping the quotes that are auto populated maybe?
daniloc@DAir wizard % pnpm try --install-dir='/Users/daniloc/Documents/Dev/wizard/e2e-tests/test-applications/nextjs-app-router-test-app'
> @posthog/wizard@1.2.2 try /Users/daniloc/Documents/Dev/wizard
> ts-node bin.ts --install-dir\=/Users/daniloc/Documents/Dev/wizard/e2e-tests/test-applications/nextjs-app-router-test-app
┌ Welcome to the PostHog setup wizard ✨
│
■ Could not find package.json. Make sure to run the wizard in the root of your app!
│
└ Wizard setup cancelled.
There was a problem hiding this comment.
hmm does it work without the quotes?
There was a problem hiding this comment.
path resolution bug; will patch
…on-strategy # Conflicts: # src/nextjs/nextjs-wizard.ts
* Use history_change instead of a manual pageview function call * Add docs for instrumentation-client and logic to select * Update next wizard for instrumentation-client file * Update readme with local testing guidance * Move testing content * Fix comment * Prettier * const (okay face) * 😑 * Add instrumentation-client test app * Update output message * Remove stray import * Allow absolute paths as --install-dir values * Update readme * Make it copyable * well that didn’t help
This pull:
integration-client.ts|js, gated upon version (15.3 and up): https://nextjs.org/docs/app/api-reference/file-conventions/instrumentation-clientPostHogPageView()component stuff in favor of the newhistory_changefeature