feat: add related filters #4011
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurenceisla
commented
Apr 13, 2025
Comment on lines
382
to
451
| context "related conditions using the embed(column) syntax" $ do | ||
| it "can do an or across embeds" $ | ||
| get "/client?select=*,clientinfo(),contact()&or=(clientinfo(other).like.*Main*,contact(name).like.*Tabby*)" `shouldRespondWith` | ||
| [json|[ | ||
| {"id":1,"name":"Walmart"}, | ||
| {"id":2,"name":"Target"} | ||
| ]|] | ||
| { matchStatus = 200 | ||
| , matchHeaders = [matchContentTypeJson] | ||
| } |
There was a problem hiding this comment.
Currently working for the simplest case, e.g. (didn't use empty embeds to illustrate):
curl 'localhost:3000/client?select=*,clientinfo(other),contact(name)&or=(clie
ntinfo(other).like.*Main*,contact(name).like.*Tabby*)'Gives the same result as:
curl 'localhost:3000/client?select=*,clientinfo(other),contact(name)&clientin
fo.other=like.*Main*&contact.name=like.*Tabby*&or=(clientinfo.not.is.null,contact.not.is.null)'[
{"id":1, "name":"Walmart", "clientinfo":[{"other": "123 Main St"}], "contact":[]},
{"id":2, "name":"Target", "clientinfo":[], "contact":[{"name": "Tabby Targo"}]}
]There are other possible cases that need to be considered. One of those is how to use this syntax to filter nested relationships #3726 (reply in thread)
laurenceisla
force-pushed
the
feat-rel-filters
branch
from
d5c87f9 to
26e5ed9
Compare
laurenceisla
force-pushed
the
feat-rel-filters
branch
from
26e5ed9 to
74ed322
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement related AND/OR according to #2563 (comment)
embed(col)=eq.val.or=(embed1(col1).eq.val1,embed2(col2).eq.val2)