nix: shorten postgrest-with-postgresql-xx scripts
#4469
+27
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taimoorzaeem
force-pushed
the
nix/fix-unix-socket-length
branch
from
2c2c72b to
71ada9d
Compare
Member
wolfgangwalther
left a comment
wolfgangwalther
left a comment
There was a problem hiding this comment.
I'm fine with renaming, but let's separate the socket change into another commit.
Also please have a look at this:
postgrest/nix/overlays/checked-shell-script/checked-shell-script.nix
Lines 107 to 108 in 5318483
I think we can just remove the /postgrest/ path component entirely - we will have that part as prefix in every name anyway.
nix/tools/withTools.nix
Outdated
Comment on lines
90
to
96
| replica_host="$tmpdir/socket_$replica_slot" | ||
| replica_host="$tmpdir/sock_$replica_slot" |
Member
There was a problem hiding this comment.
We should just run the replica on the same socket path as the primary, but use a different port (it will then create a different socket). That would save a whole level of the path.
Collaborator
Author
There was a problem hiding this comment.
Great idea! I will try to do these changes in a separate PR.
Renames these scripts to `postgrest-with-pg-xx`. The renaming helps reduce the length of temporary filenames. This is needed to ensure that socket file names remain under the maximum allowed length of 107 chars. Closes PostgREST#4461. Signed-off-by: Taimoor Zaeem <[email protected]>
taimoorzaeem
force-pushed
the
nix/fix-unix-socket-length
branch
from
71ada9d to
7210385
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renames these scripts to
postgrest-with-pg-xx. The renaming helps reduce the length of temporary filenames. This is needed to ensure that socket file names remain under the maximum allowed length of 107 chars.Closes #4461.