Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughThe Tailwind CSS configuration was updated to include a new Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms (1)
🔇 Additional comments (1)
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
apps/app/src/components/ui/toast.tsx(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Run Tests
apps/app/src/components/ui/toast.tsx
Outdated
Comment on lines
+31
to
+32
| destructive: | ||
| "destructive group border-destructive bg-destructive text-destructive-foreground", | ||
| "destructive group border-destructive bg-destructive text-destructive-foreground bg-red-100", |
There was a problem hiding this comment.
🛠️ Refactor suggestion
❓ Verification inconclusive
Avoid conflicting background utilities.
Adding bg-red-100 alongside bg-destructive results in two competing background classes. If your goal is to lighten the destructive toast, prefer a semantic opacity utility (e.g. bg-destructive/20) or remove the original bg-destructive so only the intended color applies. This avoids hard-coding palette colors and ensures theming consistency (including dark mode).
Do you want to swap to an opacity-based class like bg-destructive/10 instead of bg-red-100?
Avoid conflicting background utilities.
Adding bg-red-100 alongside bg-destructive results in two competing background classes. If your goal is to lighten the destructive toast, prefer a semantic opacity utility (e.g. bg-destructive/20) or remove the original bg-destructive so only the intended color applies. This avoids hard-coding palette colors and ensures theming consistency (including dark mode).
Do you want to swap to an opacity-based class like bg-destructive/10 instead of bg-red-100?
🤖 Prompt for AI Agents
In apps/app/src/components/ui/toast.tsx around lines 31 to 32, the class list
for the destructive toast includes both bg-destructive and bg-red-100, causing
conflicting background styles. To fix this, remove bg-red-100 and replace it
with a semantic opacity utility like bg-destructive/10 or bg-destructive/20 to
lighten the background while preserving theming and dark mode consistency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preview of all variants of toasts
Summary by CodeRabbit