Adds branching

[elliotBraem]

Summary by CodeRabbit

• New Features

  • Introduced support for branching in processing plans, allowing steps to be grouped and executed concurrently based on branch identifiers.

• Bug Fixes

  • Improved error handling by adding bounds checking for step indices during retries and tweaks.

• Refactor

  • Enhanced processing logic for more precise handling of branch-specific steps and partial plan extraction.

• Documentation

  • Updated schema to include an optional branch identifier for processing steps.

[coderabbitai]

Walkthrough

Branching logic was introduced into the processing workflow by adding a branchId to processing plan steps. The processing service now executes global steps sequentially and processes branch-specific steps concurrently, grouping them by branchId. Retry and tweak logic was updated to operate within specific branches. The processing plan schema was updated to support the new branchId field.

Changes

File(s)	Change Summary
packages/core-services/src/services/processing.service.ts	Refactored processing logic for branching, updated retry/tweak logic, and plan building to use branchId.
packages/shared-db/src/schema/processing.ts	Added optional branchId field to ProcessingPlanStepSchema.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant ProcessingService
    participant GlobalSteps
    participant Branches

    Client->>ProcessingService: process(content, config, options)
    ProcessingService->>GlobalSteps: Execute global steps sequentially
    GlobalSteps->>ProcessingService: Return global output
    ProcessingService->>Branches: For each branchId, execute steps concurrently with global output
    Branches->>ProcessingService: Return branch outputs
    ProcessingService->>Client: Return combined results

Loading

Poem

In the warren of logic, new branches now grow,
Each with a branchId, to help processing flow.
Global steps march, then the branches all run,
Concurrency hopping—oh, what fun!
With tweaks and retries, the plan’s never stuck,
This rabbit’s code brings branching luck! 🐇🌿

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d1e8f9f and ec44589.

📒 Files selected for processing (2)

• packages/core-services/src/services/processing.service.ts (4 hunks)
• packages/shared-db/src/schema/processing.ts (1 hunks)

🔇 Additional comments (3)

packages/shared-db/src/schema/processing.ts (1)

60-62: LGTM!

The addition of the optional branchId field is well-designed and maintains backward compatibility.

packages/core-services/src/services/processing.service.ts (2)

369-388: LGTM!

The branchId assignment correctly groups distributor transforms and distribution steps together, enabling proper branch execution.

---

117-143: Fix race condition in concurrent branch execution.

The executedSteps array is being modified concurrently by multiple branch promises without synchronization. This could lead to race conditions and lost updates.

Consider collecting steps from each branch and merging them after all branches complete:

-      const branchPromises = Array.from(branchesWithOrder.values()).map(
-        async (branch) => {
+      const branchResults = await Promise.all(
+        Array.from(branchesWithOrder.values()).map(async (branch) => {
+          const branchSteps: SelectProcessingStep[] = [];
           let branchContent = globalOutput;
           for (const planStep of branch) {
             if (planStep.type === "transformation") {
               const result = await this.executeTransform(
                 job.id,
                 branchContent,
                 planStep,
                 planStep.order,
               );
-              executedSteps.push(result.step);
+              branchSteps.push(result.step);
               branchContent = result.output;
             } else if (planStep.type === "distribution") {
               const step = await this.executeDistribution(
                 job.id,
                 branchContent,
                 planStep,
                 planStep.order,
               );
-              executedSteps.push(step);
+              branchSteps.push(step);
             }
           }
-        },
+          return branchSteps;
+        })
       );
-
-      await Promise.all(branchPromises);
+      
+      // Merge all branch steps
+      branchResults.forEach(branchSteps => executedSteps.push(...branchSteps));

Likely an incorrect or invalid review comment.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
curatedotfun-app	⬜️ Skipped (Inspect)			Jul 11, 2025 3:14pm