Skip to content

Fix Additional Packages dropdown becoming permanently disabled #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Power-Maverick merged 2 commits into from
Sep 30, 2025
Merged

Fix Additional Packages dropdown becoming permanently disabled #75

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a8dc999
Initial plan
Copilot Sep 28, 2025
7cc6f2f
Fix Additional Packages dropdown behavior for Virtual/non-Virtual con…
Copilot Sep 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Maverick.PCF.Builder.DataObjects/ControlManifestDetails.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ public ControlManifestDetails()
Properties = new List<ControlProperty>();
Features = new List<Feature>();
IsVirtual = false;
AdditionalPackageIndex = 0; // Default to "None" (first item in the dropdown)
}

public string WorkingFolderPath { get; set; }
Expand Down
10 changes: 9 additions & 1 deletion Maverick.PCF.Builder/PCFBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -738,6 +738,9 @@ private void PopulateControlDetails()

cboxControlType.SelectedIndex = ControlDetails.IsVirtual ? 1 : 0;
cboxTemplate.SelectedIndex = ControlDetails.IsDatasetTemplate ? 1 : 0;

// Restore the additional package selection from saved control details
cboxAdditionalPackages.SelectedIndex = ControlDetails.AdditionalPackageIndex;

if (!string.IsNullOrEmpty(ControlDetails.PreviewImagePath))
{
Expand Down Expand Up @@ -2666,11 +2669,16 @@ private void btnManageFeatures_Click(object sender, EventArgs e)

private void cboxControlType_SelectedIndexChanged(object sender, EventArgs e)
{
if ((string)cboxControlType.SelectedItem == "Virtual")
if (cboxControlType.SelectedItem != null && (string)cboxControlType.SelectedItem == "Virtual")
{
cboxAdditionalPackages.SelectedIndex = 1;
cboxAdditionalPackages.Enabled = false;
}
else
{
// Re-enable the additional packages dropdown for non-Virtual control types
cboxAdditionalPackages.Enabled = true;
}
}

#endregion
Expand Down