upgrade Go, Docker base img., fix #73 & #84#86
Closed
joel-ling wants to merge 8 commits intoPowerDNS:mainfrom
Closed
upgrade Go, Docker base img., fix #73 & #84#86joel-ling wants to merge 8 commits intoPowerDNS:mainfrom
joel-ling wants to merge 8 commits intoPowerDNS:mainfrom
Conversation
joel-ling
commented
Mar 24, 2025
| - name: check-spelling | ||
| id: spelling | ||
| uses: check-spelling/check-spelling@v0.0.21 | ||
| uses: check-spelling/check-spelling@v0.0.24 |
Member
Author
There was a problem hiding this comment.
check-spelling is upgraded here, but it appears the Actions runner did not catch up with the change:
Download action repository 'check-spelling/check-spelling@v0.0.21' (SHA:d7cd2973c513e84354f9d6cf50a6417a628a78ce)
nvaatstra
reviewed
Mar 24, 2025
nvaatstra
reviewed
Mar 25, 2025
Contributor
nvaatstra
left a comment
nvaatstra
left a comment
There was a problem hiding this comment.
Time comparison looks good now, however go.mod and go.sum seem like they need to be rebuilt
ahouene
approved these changes
Mar 25, 2025
Contributor
ahouene
left a comment
ahouene
left a comment
There was a problem hiding this comment.
A small nit about using the external slices package, and indeed go mod tidy is probably required, otherwise LGTM!
Member
Author
|
Looks like we won't be needing this PR anymore: #87 Thanks @ahouene and @nvaatstra for your helpful comments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also resolves #65 by upgrading
simpleblobto v0.3.0 > v0.2.6: PowerDNS/simpleblob#50