PR on #94: add AsymPowerSensorArray and remove optional columns from GenericBranch #113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thijs Baaijen <[email protected]>
Signed-off-by: Thijs Baaijen <[email protected]>
Signed-off-by: Thijs Baaijen <[email protected]>
Thijss
changed the base branch from
feat/add-basic-arrays
to
feature/45-add-extra-pgm-components
Signed-off-by: Thijs Baaijen <[email protected]>
Signed-off-by: Thijs Baaijen <[email protected]>
|
Thijss
changed the title
Thijss
changed the title
Thijss
commented
Nov 13, 2025
| x1: NDArray[np.float64] # positive-sequence reactance | ||
| g1: NDArray[np.float64] # positive-sequence conductance | ||
| b1: NDArray[np.float64] # positive-sequence susceptance | ||
| k: NDArray[np.float64] # off-nominal ratio |
Member
Author
There was a problem hiding this comment.
@vincentkoppen and me think it's better to leave these out, so that PGM can handle the defaults. If a user wants to provide other values, they can easily extend there GenericBranchArray. This is also how we do it in other array (e.g., SourceArray, LineArray)
Thijss
commented
Nov 13, 2025
| for field in sym_pow_fields: | ||
| assert field in pow_sens.dtype.fields | ||
|
|
||
| def test_asymmetric_sensor_array(): |
Member
Author
There was a problem hiding this comment.
the first part of the original test did't really test anything useful
Thijss
commented
Nov 13, 2025
| "generic_branch", | ||
| "asym_line", | ||
| "sym_gen", | ||
| "asym_power_sensor", |
Member
Author
There was a problem hiding this comment.
sorted the fields for better readability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
AsymPowerSensorArrayand remove defaults fromGenericBranch