Skip to content

Conversation

@vincentkoppen
Copy link
Member

@vincentkoppen vincentkoppen commented Nov 12, 2025

Fixes issue: #112

Changes proposed in this PR include:

Currently we have a hardcoded list of arrays to convert to input_data.
This PR relies on ComponentType from PGM as a complete set off possible values. This also allows user to add a new component before we do with a working interface layer.

  • Loop over this instead of our hardcoded list
  • Need extra to check at some places if the array exists (if PGM adds a new component type, we shouldn't break)
  • Also renamed the load_flow file to easier find the interface in the code ;)

@vincentkoppen vincentkoppen marked this pull request as draft November 13, 2025 15:40
@vincentkoppen vincentkoppen force-pushed the feat/use-component-type branch 2 times, most recently from 882b779 to 8fab94b Compare December 3, 2025 14:29
@vincentkoppen vincentkoppen force-pushed the feat/use-component-type branch from 8fab94b to abfc158 Compare December 3, 2025 14:30
@vincentkoppen vincentkoppen marked this pull request as ready for review December 3, 2025 14:31
Signed-off-by: Vincent Koppen <[email protected]>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 3, 2025

@sonarqubecloud
Copy link

Copy link
Member

@Thijss Thijss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vincentkoppen vincentkoppen merged commit 5545d38 into main Jan 14, 2026
16 checks passed
@vincentkoppen vincentkoppen deleted the feat/use-component-type branch January 14, 2026 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants