feat(BaseGraph): deprecation warning for substation_nodes argument in get_components #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentkoppen
force-pushed
the
feat/improve_get_components
branch
2 times, most recently
from
c4fb7bb to
9f3bd5b
Compare
vincentkoppen
commented
Jan 29, 2025
vincentkoppen
force-pushed
the
feat/improve_get_components
branch
2 times, most recently
from
9167327 to
68adcd2
Compare
vincentkoppen
commented
Feb 1, 2025
Member
|
For some reason I do not see the performance boost when comparing the tests in https://github.com/PowerGridModel/power-grid-model-ds/blob/main/tests/performance/graph_performance_tests.py to main... |
Thijss
reviewed
Feb 3, 2025
Thijss
force-pushed
the
feat/improve_get_components
branch
from
24b000d to
0351b12
Compare
Thijss
reviewed
Feb 3, 2025
vincentkoppen
commented
Feb 26, 2025
vincentkoppen
force-pushed
the
feat/improve_get_components
branch
from
d38b33a to
7b31366
Compare
vincentkoppen
changed the title
Signed-off-by: Vincent Koppen <[email protected]>
vincentkoppen
force-pushed
the
feat/improve_get_components
branch
from
7b31366 to
554a71a
Compare
vincentkoppen
commented
Feb 26, 2025
|
vincentkoppen
requested review from
Thijss,
jaapschoutenalliander and
svenvdvoort
jaapschoutenalliander
approved these changes
Feb 27, 2025
Member
jaapschoutenalliander
left a comment
jaapschoutenalliander
left a comment
There was a problem hiding this comment.
Clear warning, nicely done
Signed-off-by: Thijs Baaijen <[email protected]>
|
Thijss
approved these changes
Apr 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_componentsto use the newtmp_remove_nodescontext manager instead of copying the graphsubstation_nodesargument in theget_componentsfunctionget_componentswithout any argument.