fix: delete_branch3 used wrong argument name #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vincent Koppen <[email protected]>
|
Thijss
approved these changes
Feb 4, 2025
Thijss
pushed a commit
that referenced
this pull request
Feb 5, 2025
Signed-off-by: Vincent Koppen <[email protected]>
Thijss
added a commit
that referenced
this pull request
Feb 5, 2025
* feat: improve downstream nodes performance with local search Signed-off-by: jaapschoutenalliander <[email protected]> * test: add testing on sorting Signed-off-by: jaapschoutenalliander <[email protected]> * chore: update performance test Signed-off-by: jaapschoutenalliander <[email protected]> * Add .find_connected method and alter .get_downstream_nodes Signed-off-by: Thijs Baaijen <[email protected]> * Update test_get_downstream_nodes Co-authored-by: jaapschoutenalliander <[email protected]> Signed-off-by: Thijs Baaijen <[email protected]> * Update performance tests Co-authored-by: jaapschoutenalliander <[email protected]> Signed-off-by: Thijs Baaijen <[email protected]> * rename to find_first_connected and update docstring Signed-off-by: Thijs Baaijen <[email protected]> * Feature: add Grid.from_txt method Signed-off-by: Thijs Baaijen <[email protected]> * support unordered branches Signed-off-by: Thijs Baaijen <[email protected]> * update documentation Signed-off-by: Thijs Baaijen <[email protected]> * update gitignore Signed-off-by: Thijs Baaijen <[email protected]> * update documentation Signed-off-by: Thijs Baaijen <[email protected]> * fix test Signed-off-by: Thijs Baaijen <[email protected]> * update downstream tests Signed-off-by: Thijs Baaijen <[email protected]> * ruff Signed-off-by: Thijs Baaijen <[email protected]> * switch to regex for better text support Signed-off-by: Thijs Baaijen <[email protected]> * add support for both list[str] and str Signed-off-by: Thijs Baaijen <[email protected]> * add test for docstring Signed-off-by: Thijs Baaijen <[email protected]> * switch to args input Signed-off-by: Thijs Baaijen <[email protected]> * fix constants for graph performance tests (#28) Signed-off-by: Thijs Baaijen <[email protected]> * fix: delete_branch3 used wrong argument name (#29) Signed-off-by: Vincent Koppen <[email protected]> * chore: remove unused/nonfunctional cache on graphcontainer (#30) Signed-off-by: Vincent Koppen <[email protected]> * Feature: add Grid.from_txt method Signed-off-by: Thijs Baaijen <[email protected]> * support unordered branches Signed-off-by: Thijs Baaijen <[email protected]> * update documentation Signed-off-by: Thijs Baaijen <[email protected]> * update gitignore Signed-off-by: Thijs Baaijen <[email protected]> * update documentation Signed-off-by: Thijs Baaijen <[email protected]> * fix test Signed-off-by: Thijs Baaijen <[email protected]> * update downstream tests Signed-off-by: Thijs Baaijen <[email protected]> * add TestFindFirstConnected Signed-off-by: Thijs Baaijen <[email protected]> * remove re module implementation Signed-off-by: Thijs Baaijen <[email protected]> * bump minor Signed-off-by: Thijs Baaijen <[email protected]> * re-add grid logic from downstream nodes Co-authored-by: jaapschoutenalliander <[email protected]> Signed-off-by: Thijs Baaijen <[email protected]> --------- Signed-off-by: jaapschoutenalliander <[email protected]> Signed-off-by: Thijs Baaijen <[email protected]> Signed-off-by: Vincent Koppen <[email protected]> Co-authored-by: jaapschoutenalliander <[email protected]> Co-authored-by: Vincent Koppen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: delete_branch3 crashes on GraphContainer
Currently the
delete_branch3has a different api fromadd_branch3and the container called it wrongly.https://github.com/PowerGridModel/power-grid-model-ds/blob/00a7d2dcc4b8732efd1bf46d9915fc94b1c338e9/src/power_grid_model_ds/_core/model/graphs/container.py#L83C19-L83C39
This fixes the integration to the container and makes the API identical to
add_branch3and adds somes tests for it.