Skip to content

Conversation

@IrenaDk
Copy link
Contributor

@IrenaDk IrenaDk commented Mar 4, 2025

Change use of error NoPathBetweenNodes

Changes proposed in this PR include:

  • remove error from get_all_paths
  • keep error in get_shortest_path due to different behavior of this method compared to get_all_paths

@IrenaDk IrenaDk marked this pull request as draft March 4, 2025 10:43
@IrenaDk IrenaDk marked this pull request as ready for review March 4, 2025 10:45
IrenaDk added 2 commits March 4, 2025 13:26
I, IrenaDk <[email protected]>, hereby add my Signed-off-by to this commit: 2f35616

Signed-off-by: IrenaDk <[email protected]>
@Thijss Thijss changed the title Remove NoPathBetweenNodes from get_all_paths Breaking: Don't raise NoPathBetweenNodes in get_all_paths Mar 4, 2025
@Thijss Thijss changed the title Breaking: Don't raise NoPathBetweenNodes in get_all_paths Don't raise NoPathBetweenNodes in get_all_paths (breaking change)) Mar 4, 2025
@Thijss Thijss changed the title Don't raise NoPathBetweenNodes in get_all_paths (breaking change)) Don't raise NoPathBetweenNodes in get_all_paths (breaking change) Mar 4, 2025
@Thijss Thijss added do-not-merge This should not be merged next-minor-release labels Mar 4, 2025
@Thijss Thijss removed the do-not-merge This should not be merged label Apr 18, 2025
Signed-off-by: Thijs Baaijen <[email protected]>
@Thijss Thijss enabled auto-merge (squash) April 18, 2025 19:16
@Thijss Thijss merged commit ede0ad0 into PowerGridModel:main Apr 18, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants