Skip to content

Feat/add visualizer #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 47 commits into from
Apr 18, 2025
Merged

Feat/add visualizer #47

merged 47 commits into from
Apr 18, 2025

Conversation

@Thijss
Copy link
Member

@Thijss Thijss commented Mar 20, 2025 •
edited
Loading

This PR adds (optional) visualizing functionality to PGM-DS 🚀

ToDo:

  • > 80% test coverage
  • some linting issues
  • add graph legend (optional)
  • make the search form prettier
  • switch graph layouts in frontend
  • add documentation below to read-the-docs

(docs/visualizer.md)

@Thijss Thijss mentioned this pull request Mar 25, 2025
Open
Thijss and others added 15 commits March 30, 2025 14:15
@Thijss
adjust view height
fb7ff04
@Thijss
cleanup
403bd30
@Thijss
remove uv.lock
d47df1e
@Thijss
add REUSE Compliance
5e8475d
@Thijss
make visualize import optional and
32a00d8 
DCO Remediation Commit for Thijs Baaijen <[email protected]>

I, Thijs Baaijen <[email protected]>, hereby add my Signed-off-by to this commit: 8523654
I, Thijs Baaijen <[email protected]>, hereby add my Signed-off-by to this commit: 5426cc8
I, Thijs Baaijen <[email protected]>, hereby add my Signed-off-by to this commit: 11b422a
I, Thijs Baaijen <[email protected]>, hereby add my Signed-off-by to this commit: 735e2e4
I, Thijs Baaijen <[email protected]>, hereby add my Signed-off-by to this commit: e58a463
I, Thijs Baaijen <[email protected]>, hereby add my Signed-off-by to this commit: f3041a7
I, Thijs Baaijen <[email protected]>, hereby add my Signed-off-by to this commit: 8c460b3
I, Thijs Baaijen <[email protected]>, hereby add my Signed-off-by to this commit: 32502fc
I, Thijs Baaijen <[email protected]>, hereby add my Signed-off-by to this commit: 0520977
I, Thijs Baaijen <[email protected]>, hereby add my Signed-off-by to this commit: fb3aee2
I, Thijs Baaijen <[email protected]>, hereby add my Signed-off-by to this commit: 78fd55f
I, Thijs Baaijen <[email protected]>, hereby add my Signed-off-by to this commit: b19ffa8
I, Thijs Baaijen <[email protected]>, hereby add my Signed-off-by to this commit: ff38bb2
I, Thijs Baaijen <[email protected]>, hereby add my Signed-off-by to this commit: dae8686
I, Thijs Baaijen <[email protected]>, hereby add my Signed-off-by to this commit: fb7ff04
I, Thijs Baaijen <[email protected]>, hereby add my Signed-off-by to this commit: 403bd30
I, Thijs Baaijen <[email protected]>, hereby add my Signed-off-by to this commit: d47df1e
I, Thijs Baaijen <[email protected]>, hereby add my Signed-off-by to this commit: 5e8475d

Signed-off-by: Thijs Baaijen <[email protected]>
@Thijss
move visualizer import
e5cb443 
Signed-off-by: Thijs Baaijen <[email protected]>
@Thijss
cleanup code
55389f3 
Signed-off-by: Thijs Baaijen <[email protected]>
@Thijss
install visualizer deps in CI
40e9761 
Signed-off-by: Thijs Baaijen <[email protected]>
@Thijss
Add parser tests
10ba51c 
Signed-off-by: Thijs Baaijen <[email protected]>
@Thijss
Add REUSE compliance
c498ffc 
Signed-off-by: Thijs Baaijen <[email protected]>
@Thijss
Install visualizer in CI
678a9ee 
Signed-off-by: Thijs Baaijen <[email protected]>
@Thijss
cleanup
92597c0 
Signed-off-by: Thijs Baaijen <[email protected]>
@Thijss
add visualizer dependencies to 'dev' group too
2cbcd3a 
Signed-off-by: Thijs Baaijen <[email protected]>
@Thijss
move CoordinatedNodeArray
422d76f 
Signed-off-by: Thijs Baaijen <[email protected]>
@Thijss
Add documentation
c15a384 
Signed-off-by: Thijs Baaijen <[email protected]>
Thijss added 5 commits March 31, 2025 23:56
@Thijss
Add port parameter
f33bd47 
Signed-off-by: Thijs Baaijen <[email protected]>
@Thijss
move vis-deps to correct group
63069de 
Signed-off-by: Thijs Baaijen <[email protected]>
@Thijss
Add reuse
1f1f0b0 
Signed-off-by: Thijs Baaijen <[email protected]>
@Thijss
rename main.py to app.py
c4c509a 
Signed-off-by: Thijs Baaijen <[email protected]>
@Thijss
add layout test
bf563e4 
Signed-off-by: Thijs Baaijen <[email protected]>
jaapschoutenalliander
jaapschoutenalliander reviewed Apr 10, 2025
View reviewed changes
Copy link
Member

@jaapschoutenalliander jaapschoutenalliander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice

Thijss and others added 11 commits April 18, 2025 11:39
@Thijss
exclude visualizer from coverage
bff8c2b 
Signed-off-by: Thijs Baaijen <[email protected]>
@Thijss
Update visualizer docs with disclaimer
3bf3f1b 
Signed-off-by: Thijs Baaijen <[email protected]>
@Thijss
re-enable visualizer tests
f26873e 
Signed-off-by: Thijs Baaijen <[email protected]>
@Thijss
Update docs
a4e6585 
Signed-off-by: Thijs Baaijen <[email protected]>
@Thijss @jaapschoutenalliander
Update pyproject.toml
985da8d 
Co-authored-by: Jaap Schouten <[email protected]>
Signed-off-by: Thijs Baaijen <[email protected]>
@Thijss
Add basic test for get_app_layout
cf74704 
Signed-off-by: Thijs Baaijen <[email protected]>
@Thijss
Merge remote-tracking branch 'origin/feat/add-visualizer' into feat/a…
5d583b2 
…dd-visualizer
@Thijss
clenaup
e896064 
Signed-off-by: Thijs Baaijen <[email protected]>
@Thijss
add type hints
02c3ba1 
Signed-off-by: Thijs Baaijen <[email protected]>
@Thijss
add callback tests
be09046 
Signed-off-by: Thijs Baaijen <[email protected]>
@Thijss
use constants
e254271 
Signed-off-by: Thijs Baaijen <[email protected]>
@Thijss Thijss marked this pull request as ready for review April 18, 2025 12:29
@Thijss
bump minor version
f815151 
Signed-off-by: Thijs Baaijen <[email protected]>
jaapschoutenalliander
jaapschoutenalliander approved these changes Apr 18, 2025
View reviewed changes
Copy link
Member

@jaapschoutenalliander jaapschoutenalliander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great first visualizer release

@Thijss Thijss enabled auto-merge (squash) April 18, 2025 19:18
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 18, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
83.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Thijss Thijss merged commit 61d2599 into main Apr 18, 2025
19 checks passed
@Thijss Thijss deleted the feat/add-visualizer branch April 18, 2025 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaapschoutenalliander jaapschoutenalliander jaapschoutenalliander approved these changes

Assignees

No one assigned

Labels

next-minor-release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Thijss @jaapschoutenalliander