Skip to content

refactor: make PowerGridModelInterface._setup_model a public method #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jul 18, 2025
Merged

refactor: make PowerGridModelInterface._setup_model a public method #59

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
9afbbb5
Make PowerGridModelInterface._setup_model a public method
Thijss May 7, 2025
4129633
Merge remote-tracking branch 'origin/main' into feat/setup-model-public
Thijss Jul 17, 2025
634b221
Refactor some tests
Thijss Jul 17, 2025
74d2819
Refactor loadflow tests
Thijss Jul 17, 2025
8bae7d6
Merge remote-tracking branch 'origin/main' into feat/setup-model-public
Thijss Jul 17, 2025
940b9c3
Fix tests
Thijss Jul 17, 2025
bbaf7c5
Move tests into class
Thijss Jul 17, 2025
36f3dec
Merge branch 'chore/refactor-loadflow-tests' into feat/setup-model-pu…
Thijss Jul 17, 2025
933d78e
Add test_setup_model
Thijss Jul 17, 2025
e541a52
Merge remote-tracking branch 'origin/main' into chore/refactor-loadfl…
Thijss Jul 17, 2025
46272b5
Merge remote-tracking branch 'origin/chore/refactor-loadflow-tests' i…
Thijss Jul 17, 2025
785b00b
Update test
Thijss Jul 17, 2025
68c7ffc
Merge remote-tracking branch 'origin/main' into feat/setup-model-public
Thijss Jul 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/power_grid_model_ds/_core/load_flow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ def calculate_power_flow(

Returns output of the power flow calculation (also stored in self.output_data)
"""
self.model = self.model or self._setup_model()
self.model = self.model or self.setup_model()

self.output_data = self.model.calculate_power_flow(
calculation_method=calculation_method, update_data=update_data, **kwargs
Expand Down Expand Up @@ -134,7 +134,7 @@ def update_model(self, update_data: Dict):


"""
self.model = self.model or self._setup_model()
self.model = self.model or self.setup_model()
self.model.update(update_data=update_data)

def update_grid(self) -> None:
Expand All @@ -154,7 +154,8 @@ def update_grid(self) -> None:
def _match_dtypes(first_dtype: np.dtype, second_dtype: np.dtype):
return list(set(first_dtype.names).intersection(set(second_dtype.names))) # type: ignore[arg-type]

def _setup_model(self):
def setup_model(self):
"""Setup the PowerGridModel with the input data."""
self.input_data = self.input_data or self.create_input_from_grid()
self.model = PowerGridModel(self.input_data, system_frequency=self.system_frequency)
return self.model
Loading