Skip to content

Conversation

@vincentkoppen
Copy link
Member

@vincentkoppen vincentkoppen commented Jan 20, 2025

Fixes failing test.

Signed-off-by: Vincent Koppen <[email protected]>
Co-authored-by: Thijs Baaijen <[email protected]>
Signed-off-by: Vincent Koppen <[email protected]>
@vincentkoppen vincentkoppen requested a review from Thijss January 21, 2025 09:49
@sonarqubecloud
Copy link

Copy link
Member

@jaapschoutenalliander jaapschoutenalliander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solution is fine by me, I do wonder why this failed only for Martijn, any idea why?

@mgovers
Copy link
Member

mgovers commented Jan 22, 2025

Solution is fine by me, I do wonder why this failed only for Martijn, any idea why?

maybe Windows and/or Python 3.13?

@vincentkoppen
Copy link
Member Author

Solution is fine by me, I do wonder why this failed only for Martijn, any idea why?

maybe Windows and/or Python 3.13?

It's really odd, since we do test for Windows and 3.13 in the pipeline. So not sure what could be different in the setup to cause this issue.

@jaapschoutenalliander jaapschoutenalliander merged commit 4a36057 into main Jan 22, 2025
21 checks passed
@jaapschoutenalliander jaapschoutenalliander deleted the chore/fix_test branch January 22, 2025 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants