Skip to content

feat: add from_extended methods #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jul 17, 2025
Merged

feat: add from_extended methods #76

merged 11 commits into from
Jul 17, 2025

Conversation

@Thijss
Copy link
Member

@Thijss Thijss commented Jul 16, 2025 •
edited
Loading

Adds

base_line_array = LineArray.from_extended(my_extended_line_array)

And

base_grid = Grid.from_extended(my_extended_grid)

Thijss added 5 commits July 16, 2025 17:30
@Thijss
Add FancyArray.from_extended
6bebd28 
Signed-off-by: Thijs Baaijen <[email protected]>
@Thijss
switch extended arrays
72e3c61 
Signed-off-by: Thijs Baaijen <[email protected]>
@Thijss
fix tests
4e779fb 
Signed-off-by: Thijs Baaijen <[email protected]>
@Thijss
Add Grid.from_extended
b47c97e 
Signed-off-by: Thijs Baaijen <[email protected]>
@Thijss
cleanup
13fcb93 
Signed-off-by: Thijs Baaijen <[email protected]>
@Thijss Thijss changed the title Add extended method Add from_extended methods Jul 16, 2025
@Thijss Thijss marked this pull request as ready for review July 16, 2025 16:06
@Thijss Thijss changed the title Add from_extended methods Feat: add from_extended methods Jul 16, 2025
vincentkoppen
vincentkoppen reviewed Jul 17, 2025
View reviewed changes
Copy link
Member

@vincentkoppen vincentkoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some remarks, overal good functionality to support!
Do we want these to the docs/example notebooks?

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 17, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
88.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

vincentkoppen
vincentkoppen approved these changes Jul 17, 2025
View reviewed changes
Copy link
Member

@vincentkoppen vincentkoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@Thijss Thijss merged commit 49c1d95 into main Jul 17, 2025
22 checks passed
@Thijss Thijss deleted the add-extended-method branch July 17, 2025 13:35
@Thijss Thijss changed the title Feat: add from_extended methods feat: add from_extended methods Jul 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vincentkoppen vincentkoppen vincentkoppen approved these changes

@jaapschoutenalliander jaapschoutenalliander jaapschoutenalliander approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Thijss @vincentkoppen @jaapschoutenalliander