TypeError: BaseGraphModel.get_components() got an unexpected keyword argument 'substation_nodes' #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mehmet Keçeci <[email protected]>
Signed-off-by: Mehmet Keçeci <[email protected]>
jaapschoutenalliander
requested changes
Sep 11, 2025
Member
jaapschoutenalliander
left a comment
jaapschoutenalliander
left a comment
There was a problem hiding this comment.
Thank you for pointing out the issue and suggesting a fix. The suggestion works, however I have some minor other changes requested to clean up the PR
Signed-off-by: Jaap Schouten <[email protected]>
Signed-off-by: Jaap Schouten <[email protected]>
jaapschoutenalliander
approved these changes
Oct 9, 2025
Member
jaapschoutenalliander
left a comment
jaapschoutenalliander
left a comment
There was a problem hiding this comment.
Thank you for the helpful PR, it keeps te docs clean and up to date
Use tmp_remove_nodes instead of the old substation_nodes argument Signed-off-by: Vincent Koppen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue:
The example in the docs
docs/model_interface.ipynbstill uses the deprecated parametersubstation_nodes, which has been removed in a previous release. Running the example in the docs now results in the following error:TypeError: BaseGraphModel.get_components() got an unexpected keyword argument 'substation_nodes'This PR removes the deprecated parameter from the example