fix: prevent append with overlapping ids #92
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jaapschoutenalliander <[email protected]>
Thijss
reviewed
Sep 30, 2025
Signed-off-by: jaapschoutenalliander <[email protected]>
|
Thijss
approved these changes
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request improves the handling of ID assignment and validation in the model container logic to prevent accidental ID overlaps when appending arrays. It also adds new unit tests to ensure correct behavior for overlapping and non-overlapping IDs.
ID assignment and validation improvements:
_id_counterfrom0to-1in the base container to better represent an uninitialized state and prevent collisions with valid IDs._update_id_countermethod to raise aValueErrorif any incoming array's minimum ID is less than or equal to the current_id_counter, preventing ID overlaps when appending arrays with prescribed IDs. The old check for only the maximum ID being less than the counter was removed.