Skip to content

Conversation

@figueroa1395
Copy link
Member

@figueroa1395 figueroa1395 commented Jan 21, 2025

Don't merge until all the related PRs are also reviewed.

Relates to PowerGridModel/.github#47
Relates to PowerGridModel/power-grid-model#879
Relates to PowerGridModel/power-grid-model-ds#12

Signed-off-by: Santiago Figueroa Manrique <[email protected]>
@figueroa1395 figueroa1395 added dependencies Pull requests that update a dependency file do-not-merge This should not be merged labels Jan 21, 2025
@figueroa1395 figueroa1395 self-assigned this Jan 21, 2025
Signed-off-by: Santiago Figueroa Manrique <[email protected]>
Signed-off-by: Santiago Figueroa Manrique <[email protected]>
Signed-off-by: Santiago Figueroa Manrique <[email protected]>
Signed-off-by: Santiago Figueroa Manrique <[email protected]>
@figueroa1395
Copy link
Member Author

CI fails for 0310c66. Issue can be tracked to incompatibility of pandapower and pandas with python 3.13. Decision is to hold upgrading in this repo for now until further discussion.

Hence, we keep the scope of this PR at dropping 3.10, but not upgrading (yet) to 3.13.

Signed-off-by: Santiago Figueroa Manrique <[email protected]>
@sonarqubecloud
Copy link

@nitbharambe
Copy link
Member

nitbharambe commented Jan 22, 2025

https://pandas.pydata.org/docs/whatsnew/v2.2.3.html
I suppose not "officially" supported but compatible

CI fails for 0310c66. Issue can be tracked to incompatibility of pandapower and pandas with python 3.13. Decision is to hold upgrading in this repo for now until further discussion.

Hence, we keep the scope of this PR at dropping 3.10, but not upgrading (yet) to 3.13.

@figueroa1395
Copy link
Member Author

https://pandas.pydata.org/docs/whatsnew/v2.2.3.html I suppose not "officially" supported but compatible

CI fails for 0310c66. Issue can be tracked to incompatibility of pandapower and pandas with python 3.13. Decision is to hold upgrading in this repo for now until further discussion.
Hence, we keep the scope of this PR at dropping 3.10, but not upgrading (yet) to 3.13.

You are right, pandas' documentation is outdated, but they actually support python 3.13 already. So the problem here is only relevant to pandapower and the testing part in the CI specifically (see #289). Hence, this PR is ready to be reviewed + merged.

@mgovers mgovers removed the do-not-merge This should not be merged label Jan 27, 2025
@mgovers mgovers added this pull request to the merge queue Jan 27, 2025
Merged via the queue into main with commit 70f9d54 Jan 27, 2025
22 of 23 checks passed
@mgovers mgovers deleted the drop-python-3.10 branch January 27, 2025 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants