Skip to content

Conversation

@nitbharambe
Copy link
Member

No description provided.

Signed-off-by: Nitish Bharambe <[email protected]>
Signed-off-by: Nitish Bharambe <[email protected]>
Signed-off-by: Nitish Bharambe <[email protected]>
Signed-off-by: Nitish Bharambe <[email protected]>
Signed-off-by: Nitish Bharambe <[email protected]>
@mgovers
Copy link
Member

mgovers commented Apr 3, 2025

@nitbharambe what is still needed before merge?

@nitbharambe
Copy link
Member Author

@nitbharambe what is still needed before merge?

CI was failing. Ill check the issue now.

@nitbharambe nitbharambe changed the base branch from main to feautre/restrict-numpy-2.0 April 4, 2025 09:18
nitbharambe and others added 9 commits April 4, 2025 11:18
This reverts commit 1530747.

I, Nitish Bharambe <[email protected]>, hereby add my Signed-off-by to this commit: 96ade36

Signed-off-by: Nitish Bharambe <[email protected]>
….com>I, Nitish Bharambe <[email protected]>, hereby add my Signed-off-by to this commit: aad98d7c148ca1a6bd87b7f7e62af788cfd38e24I, Nitish Bharambe <[email protected]>, hereby add my Signed-off-by to this commit: 7f6c163090011e70c788f52c01e6353c38420a61Signed-off-by: Nitish Bharambe <[email protected]>

Signed-off-by: Nitish Bharambe <[email protected]>
….com>I, Nitish Bharambe <[email protected]>, hereby add my Signed-off-by to this commit: aad98d7c148ca1a6bd87b7f7e62af788cfd38e24I, Nitish Bharambe <[email protected]>, hereby add my Signed-off-by to this commit: 7f6c163090011e70c788f52c01e6353c38420a61Signed-off-by: Nitish Bharambe <[email protected]>
….com>

I, Nitish Bharambe <[email protected]>, hereby add my Signed-off-by to this commit: aad98d7
I, Nitish Bharambe <[email protected]>, hereby add my Signed-off-by to this commit: 7f6c163

Signed-off-by: Nitish Bharambe <[email protected]>
….com>

I, Nitish Bharambe <[email protected]>, hereby add my Signed-off-by to this commit: 30c127e

Signed-off-by: Nitish Bharambe <[email protected]>
Signed-off-by: Nitish Bharambe <[email protected]>
@figueroa1395
Copy link
Member

Quality Gate Failed Quality Gate failed

Failed conditions 0.0% Coverage on New Code (required ≥ 80%) B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

This is probably related to https://sonarcloud.io/summary/new_code?id=PowerGridModel_power-grid-model-io (failed quality gate report), which may be related to the warning message appearing there. Also, Eziel from GOAT is facing a similar problem, so he might have an idea. This has been going for a while for no apparent reason, but I haven't had the time to investigate. Maybe you could have a look since it is now popping up here.

@nitbharambe
Copy link
Member Author

Quality Gate Failed Quality Gate failed

Failed conditions 0.0% Coverage on New Code (required ≥ 80%) B Maintainability Rating on New Code (required ≥ A)
See analysis details on SonarQube Cloud
Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

This is probably related to https://sonarcloud.io/summary/new_code?id=PowerGridModel_power-grid-model-io (failed quality gate report), which may be related to the warning message appearing there. Also, Eziel from GOAT is facing a similar problem, so he might have an idea. This has been going for a while for no apparent reason, but I haven't had the time to investigate. Maybe you could have a look since it is now popping up here.

Sonarcloud fails on main too. The issue does not originate from this branch and this branch has priority, hence we shall merge and then resolve sonar cloud in a separate branch/PR.

Base automatically changed from feautre/restrict-numpy-2.0 to main April 7, 2025 07:40
@mgovers mgovers added the feature New feature or request label Apr 7, 2025
Signed-off-by: Nitish Bharambe <[email protected]>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 7, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@mgovers
Copy link
Member

mgovers commented Apr 7, 2025

Quality Gate Failed Quality Gate failed

Failed conditions 0.0% Coverage on New Code (required ≥ 80%) B Maintainability Rating on New Code (required ≥ A)
See analysis details on SonarQube Cloud
Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

This is probably related to https://sonarcloud.io/summary/new_code?id=PowerGridModel_power-grid-model-io (failed quality gate report), which may be related to the warning message appearing there. Also, Eziel from GOAT is facing a similar problem, so he might have an idea. This has been going for a while for no apparent reason, but I haven't had the time to investigate. Maybe you could have a look since it is now popping up here.

Sonarcloud fails on main too. The issue does not originate from this branch and this branch has priority, hence we shall merge and then resolve sonar cloud in a separate branch/PR.

merging cfr. ^

@nitbharambe nitbharambe added this pull request to the merge queue Apr 7, 2025
Merged via the queue into main with commit cafd6d7 Apr 7, 2025
21 of 22 checks passed
@nitbharambe nitbharambe deleted the feature/vision-excel-config-update branch April 7, 2025 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants