Skip to content

Fix: Remove Redundent Initialization to resolve reliability issue on Pypi. #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 15, 2025
Merged

Fix: Remove Redundent Initialization to resolve reliability issue on Pypi. #327

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/power_grid_model_io/converters/pandapower_converter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -426,7 +426,6 @@ def _create_pgm_input_lines(self):
pgm_lines["x1"] = self._get_pp_attr("line", "x_ohm_per_km", expected_type="f8") * multiplier
pgm_lines["c1"] = c_nf_per_km * length_km * parallel * 1e-9
# The formula for tan1 = R_1 / Xc_1 = (g * 1e-6) / (2 * pi * f * c * 1e-9) = g / (2 * pi * f * c * 1e-3)
pgm_lines["tan1"] = 0.0
pgm_lines["tan1"] = np.divide(
self._get_pp_attr("line", "g_us_per_km", expected_type="f8", default=0),
c_nf_per_km * (2 * np.pi * self.system_frequency * 1e-3),
Expand All @@ -440,7 +439,6 @@ def _create_pgm_input_lines(self):
pgm_lines["r0"] = self._get_pp_attr("line", "r0_ohm_per_km", expected_type="f8", default=np.nan) * multiplier
pgm_lines["x0"] = self._get_pp_attr("line", "x0_ohm_per_km", expected_type="f8", default=np.nan) * multiplier
pgm_lines["c0"] = c0_nf_per_km * length_km * parallel * 1e-9
pgm_lines["tan0"] = 0.0
pgm_lines["tan0"] = np.divide(
self._get_pp_attr("line", "g0_us_per_km", expected_type="f8", default=0),
c0_nf_per_km * (2 * np.pi * self.system_frequency * 1e-3),
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/converters/test_pandapower_converter_input.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -596,7 +596,7 @@ def test_create_pgm_input_lines(mock_init_array: MagicMock, two_pp_objs, convert
pgm.assert_any_call("r0", ANY)
pgm.assert_any_call("x0", ANY)
pgm.assert_any_call("c0", ANY)
assert len(pgm.call_args_list) == 16
assert len(pgm.call_args_list) == 14

# result
assert converter.pgm_input_data[ComponentType.line] == mock_init_array.return_value
Expand Down
Loading