Skip to content

Conversation

@furqan463
Copy link
Contributor

To make it consistent with Pandapower. Currently Unbalance percent in pandapower_converter.py is V_zero / V_pos, while that defined in Pandapower is V_neg / V_pos. As per my knowledge, this is also consistent with IEC.

https://github.com/e2nIEE/pandapower/blob/develop/pandapower/results_bus.py#L71

To make it consistent with Pandapower.

Signed-off-by: Engr. Ahmad Furqan <[email protected]>
@furqan463 furqan463 changed the title **Fix** Unbalance Percent in res_bus_3ph [FIX] Unbalance Percent in res_bus_3ph Sep 24, 2025
@furqan463
Copy link
Contributor Author

furqan463 commented Sep 25, 2025

@mgovers @nitbharambe can you please review

@mgovers mgovers added the bug Something isn't working label Sep 25, 2025
@mgovers mgovers requested a review from nitbharambe September 25, 2025 04:40
@mgovers
Copy link
Member

mgovers commented Sep 25, 2025

Hi @furqan463, Good find!

@nitbharambe can you please review as the EE expert?

Can we somehow validate this? I do think this change is simple enough that we don't need explicit tests but it would be interesting to think about such a test case.

@furqan463
Copy link
Contributor Author

https://cigre-usnc.org/wp-content/uploads/2017/10/C4_Laughner.pdf

This papers refers the definitions under "Standards" section at 3.
ANSI Standard & IEEE Standards define voltage unbalance as ratio of deviation to average voltage
IEC defines voltage unbalance as ratio of negative sequence to positive sequence.

But I cannot find a reference for ratio of zero seq to positive sequence.

In Power System Protection, negative sequence is used as a measure of unbalance.

@nitbharambe
Copy link
Member

Good find indeed @furqan463
Agreed per the IEC standard and the code at pandapower.

I think we were referring to pandapower documentation when we developed the feature which is likely incorrect:
image

nitbharambe
nitbharambe previously approved these changes Sep 25, 2025
@nitbharambe nitbharambe dismissed their stale review September 25, 2025 19:30

Missed the validation part. My bad.

@furqan463
Copy link
Contributor Author

I think we were referring to pandapower documentation

Documentation Now corrected for next release of PP.

e2nIEE/pandapower#2726

@nitbharambe nitbharambe added this pull request to the merge queue Sep 29, 2025
Merged via the queue into PowerGridModel:main with commit 49c3f36 Sep 29, 2025
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants