Logic to handle optional_extra in Vision Excel converter input - #344
Merged
Conversation
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
Jerry-Jinfeng-Guo
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements logic to handle optional extra columns in the tabular converter, addressing issue #338. The feature allows specifying columns that should be included in extra_info if present but won't cause conversion failure if missing.
Key Changes:
- Added
allow_missingparameter throughout the column definition parsing chain to support optional columns - Implemented
optional_extrawrapper in column definitions to mark columns as optional - Enhanced error handling to gracefully skip missing optional columns while preserving required column behavior
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/power_grid_model_io/converters/tabular_converter.py | Core implementation of optional_extra logic with allow_missing parameter propagation and empty DataFrame handling for missing columns |
| tests/unit/converters/test_tabular_converter.py | Comprehensive test coverage for optional_extra feature including edge cases and integration tests |
| docs/converters/vision_converter.md | Documentation explaining optional_extra syntax, behavior, and use cases for Vision Excel exports |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Jerry Guo <6221579+Jerry-Jinfeng-Guo@users.noreply.github.com>
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 10 out of 13 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Jerry Guo <6221579+Jerry-Jinfeng-Guo@users.noreply.github.com>
Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Jerry Guo <6221579+Jerry-Jinfeng-Guo@users.noreply.github.com>
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
mgovers
reviewed
Dec 1, 2025
figueroa1395
reviewed
Dec 1, 2025
Comments from Martijn Co-authored-by: Martijn Govers <martijn.govers@alliander.com> Signed-off-by: Jerry Guo <6221579+Jerry-Jinfeng-Guo@users.noreply.github.com>
Comments from Martijn Co-authored-by: Martijn Govers <martijn.govers@alliander.com> Signed-off-by: Jerry Guo <6221579+Jerry-Jinfeng-Guo@users.noreply.github.com>
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
mgovers
reviewed
Dec 3, 2025
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
nitbharambe
reviewed
Dec 5, 2025
mgovers
reviewed
Dec 9, 2025
mgovers
left a comment
mgovers
left a comment
Member
There was a problem hiding this comment.
probably good to have multiple people review this as it's quite a complex PR
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
Member
|
Apologies! Did not mean to close it. Apparently, referencing that it resolves a specific comment in this PR made GitHub think that it actually resolves the entire PR. Not great. |
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
Signed-off-by: Jerry Guo <6221579+Jerry-Jinfeng-Guo@users.noreply.github.com>
Jerry-Jinfeng-Guo
enabled auto-merge
December 18, 2025 15:15
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
figueroa1395
left a comment
figueroa1395
left a comment
Member
There was a problem hiding this comment.
Minor final remarks. From my perspective we can merge after addressing them.
Side note: I resolved/addressed remaining open comments such that it wouldn't be blocking.
Signed-off-by: Jerry Guo <Jerry.Jinfeng.Guo@alliander.com>
Jerry-Jinfeng-Guo
left a comment
Jerry-Jinfeng-Guo
left a comment
Member
Author
There was a problem hiding this comment.
Comments addressed in the form of updated code, test or replies. see 734345b
|
figueroa1395
approved these changes
Dec 22, 2025
figueroa1395
left a comment
figueroa1395
left a comment
Member
There was a problem hiding this comment.
Looks good to me, nothing more to add. The remaining sonar warning is irrelevant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #338
In this PR:
optional_extra