Skip to content

Conversation

@Thijss
Copy link
Member

@Thijss Thijss commented Apr 17, 2025

Changes proposed in this PR include:

I think installation with uv is much easier, since it handles both the python installation and the virtualenv.

ToDo:

  • test on Linux/WSL
  • test on Windows

@Thijss Thijss marked this pull request as draft April 17, 2025 15:38
@Thijss Thijss changed the title Add support for uv while remaining compatible with pip Swtich to uv package manger for easy setup Apr 18, 2025
@Thijss Thijss force-pushed the feat/add-uv-support branch from c98ae4b to b13d6f5 Compare April 18, 2025 08:12
@Thijss Thijss changed the title Swtich to uv package manger for easy setup Switch to uv package manger for easy setup Apr 18, 2025
@Thijss Thijss changed the title Switch to uv package manger for easy setup Switch to uv package manager for easy setup Apr 18, 2025
@TonyXiang8787
Copy link
Member

Hi @Thijss,

Can you explain the intension of this PR? Also please fix the DCO issue.

Thijss added 4 commits May 13, 2025 08:52
Signed-off-by: Thijs Baaijen <[email protected]>
Signed-off-by: Thijs Baaijen <[email protected]>
Signed-off-by: Thijs Baaijen <[email protected]>
@Thijss Thijss force-pushed the feat/add-uv-support branch from ad7c035 to 3bf56f6 Compare May 13, 2025 06:53
@Thijss
Copy link
Member Author

Thijss commented May 13, 2025

@TonyXiang8787 DCO is fixed.

As stated in the description: I think it makes installation much easier, since uv also manages the python installation.

@Thijss Thijss marked this pull request as ready for review May 13, 2025 07:03
@petersalemink95
Copy link
Member

Next week we have 2 workshops:

  • for students at TU/e
  • during the meet-up

I propose to wait with merging till after the workshops, because people might be setting up already.

@Thijss
Copy link
Member Author

Thijss commented May 23, 2025

I ran the Windows install script for uv on an Alliander laptop with admin privileges (Beyond Trust).

powershell -ExecutionPolicy ByPass -c "irm https://astral.sh/uv/install.ps1 | iex"

Seems to work fine. Not sure whether it works on a non-admin laptop though...

Signed-off-by: Martijn Govers <[email protected]>
@mgovers mgovers force-pushed the feat/add-uv-support branch from 0f3bc05 to 7bd3bed Compare August 28, 2025 13:56
Copy link
Member

@mgovers mgovers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; tested by @nitbharambe and me

@mgovers mgovers merged commit 3a92161 into main Aug 28, 2025
2 checks passed
@mgovers mgovers deleted the feat/add-uv-support branch August 28, 2025 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants