-
Notifications
You must be signed in to change notification settings - Fork 11
Switch to uv package manager for easy setup #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c98ae4b to
b13d6f5
Compare
|
Hi @Thijss, Can you explain the intension of this PR? Also please fix the DCO issue. |
Signed-off-by: Thijs Baaijen <[email protected]>
Signed-off-by: Thijs Baaijen <[email protected]>
Signed-off-by: Thijs Baaijen <[email protected]>
Signed-off-by: Thijs Baaijen <[email protected]>
ad7c035 to
3bf56f6
Compare
|
@TonyXiang8787 DCO is fixed. As stated in the description: I think it makes installation much easier, since uv also manages the python installation. |
|
Next week we have 2 workshops:
I propose to wait with merging till after the workshops, because people might be setting up already. |
|
I ran the Windows install script for powershell -ExecutionPolicy ByPass -c "irm https://astral.sh/uv/install.ps1 | iex"Seems to work fine. Not sure whether it works on a non-admin laptop though... |
Signed-off-by: Martijn Govers <[email protected]>
0f3bc05 to
7bd3bed
Compare
mgovers
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; tested by @nitbharambe and me
Signed-off-by: Martijn Govers <[email protected]>
Changes proposed in this PR include:
I think installation with
uvis much easier, since it handles both the python installation and the virtualenv.ToDo: