Skip to content

Conversation

@Octavian368
Copy link
Contributor

Updated the Python download link to Python 3.13.3.

mgovers
mgovers previously approved these changes May 20, 2025
Copy link
Member

@mgovers mgovers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find. Thank you for your contribution!

@mgovers
Copy link
Member

mgovers commented May 20, 2025

Can you please check https://power-grid-model.readthedocs.io/en/stable/contribution/CONTRIBUTING.html#signing-the-developer-certificate-of-origin-dco ?

Basically, you will need to re-do your commit and add Signed-off-by: Joe Smith <[email protected]> to its message. https://github.com/PowerGridModel/power-grid-model-workshop/pull/31/checks?check_run_id=42540114226 contains good documentation on that.

If you are running into issues, please let me know and I can fix it for you.

@mgovers
Copy link
Member

mgovers commented May 20, 2025

you unfortunately will have to re-do your first commit, (see also https://github.com/cncf/dco2/blob/main/README.md#individual) e.g.

DCO remediation commit for User1 <[email protected]>

I, User1 <[email protected]>, hereby add my Signed-off-by to this commit: <COMMIT1_SHA>
I, User1 <[email protected]>, hereby add my Signed-off-by to this commit: <COMMIT2_SHA>

Signed-off-by: User1 <[email protected]>

Here, that would be

DCO remediation commit for Octavian Astefanei <[email protected]>

I, Octavian Astefanei <[email protected]>, hereby add my Signed-off-by to this commit: 3960593f83327564761ede1e00435118d9e3cb94

Signed-off-by: Octavian Astefanei <[email protected]>

Signed-off-by: Octavian Astefanei <[email protected]>
Signed-off-by : Octavian Astefanei <[email protected]>
Signed-off-by: Octavian Astefanei <[email protected]>
Signed-off-by: Octavian Astefanei <[email protected]>
@petersalemink95 petersalemink95 merged commit 158d18c into PowerGridModel:main May 20, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants