Merge pull request #139 from alliander-opensource/fix/bug-voltage-sensor-angle-nan

fix bug on angle nan per phase for voltage sensor

Author: TonyXiang8787

include/power_grid_model/component/voltage_sensor.hpp

@@ -87,10 +87,18 @@ class VoltageSensor : public GenericVoltageSensor {
     RealValue<sym> u_measured_;
     RealValue<sym> u_angle_measured_;
 
+    bool has_angle() const {
+        if constexpr (sym) {
+            return !is_nan(u_angle_measured_);
+        }
+        else {
+            return !u_angle_measured_.isNaN().any();
+        }
+    }
+
     SensorCalcParam<true> sym_calc_param() const final {
-        bool const has_angle = !is_nan(u_angle_measured_);
         double u_variance = u_sigma_ * u_sigma_;
-        if (has_angle) {
+        if (has_angle()) {
             ComplexValue<true> const u = pos_seq(u_measured_ * exp(1i * u_angle_measured_));
             return {u, u_variance};
         }
@@ -101,9 +109,8 @@ class VoltageSensor : public GenericVoltageSensor {
     }
 
     SensorCalcParam<false> asym_calc_param() const final {
-        bool const has_angle = !is_nan(u_angle_measured_);
         double u_variance = u_sigma_ * u_sigma_;
-        if (has_angle) {
+        if (has_angle()) {
             ComplexValue<false> const u{u_measured_ * exp(1i * u_angle_measured_)};
             return {u, u_variance};
         }

tests/cpp_unit_tests/test_voltage_sensor.cpp

@@ -223,7 +223,8 @@ TEST_CASE("Test voltage sensor") {
 
     SUBCASE("Test sym/asym calc_param for asymmetric voltage sensor, angle = nan") {
         RealValue<false> const u_measured{10.1e3 / sqrt3, 10.2e3 / sqrt3, 10.3e3 / sqrt3};
-        RealValue<false> const u_angle_measured{nan, nan, nan};
+        // if one of the angle is nan, the whole measurment is treated as no angle value
+        RealValue<false> const u_angle_measured{1.0, 2.0, nan};
         double const u_sigma = 1.0;
         double const u_rated = 10.0e3;