fix

Signed-off-by: Martijn Govers <[email protected]>

Author: mgovers

power_grid_model_c/power_grid_model/include/power_grid_model/common/calculation_info.hpp

@@ -17,8 +17,8 @@ class CalculationInfo : public NoLogger {
     using Report = std::add_lvalue_reference_t<std::add_const_t<Data>>;
     static_assert(std::same_as<Report, Data const&>);
 
-    virtual void log(LogEvent tag, double value) override { log_impl(tag, value); }
-    virtual void log(LogEvent tag, Idx value) override { log_impl(tag, static_cast<double>(value)); }
+    void log(LogEvent tag, double value) override { log_impl(tag, value); }
+    void log(LogEvent tag, Idx value) override { log_impl(tag, static_cast<double>(value)); }
 
   private:
     Data data_;

power_grid_model_c/power_grid_model/include/power_grid_model/common/logging.hpp

@@ -43,13 +43,19 @@ enum class LogEvent : int16_t {
     max_num_iter = 2248,                     // TODO(mgovers): find other error code
 };
 
-struct Logger {
+class Logger {
+  public:
     virtual void log(LogEvent tag) = 0;
     virtual void log(LogEvent tag, std::string_view message) = 0;
     virtual void log(LogEvent tag, double value) = 0;
     virtual void log(LogEvent tag, Idx value) = 0;
+    virtual ~Logger() = 0;
 
-    virtual ~Logger() = default;
+  protected:
+    Logger(Logger const&) = default;
+    Logger(Logger&&) = default;
+    Logger& operator=(Logger const&) = default;
+    Logger& operator=(Logger&&) = default;
 };
 
 } // namespace common::logging

power_grid_model_c/power_grid_model/include/power_grid_model/common/logging_impl.hpp

@@ -23,6 +23,11 @@ class NoLogger : public Logger {
     void log(LogEvent /*tag*/, Idx /*value*/) override {
         // no logging
     }
+    NoLogger(NoLogger const&) = default;
+    NoLogger(NoLogger&&) = default;
+    NoLogger& operator=(NoLogger const&) = default;
+    NoLogger& operator=(NoLogger&&) = default;
+    ~NoLogger() override = default;
 };
 
 } // namespace power_grid_model::common::logging