Cleanup main model: Make components to be forward declared

[nitbharambe]

Idea is to make components forward declared to reduce coupling.

This draft PR is created for gathering thoughts and requirements as of now.

Changes proposed in this PR include:

• Forward declared all components
• Removed unecessary exception and logging includes.

[figueroa1395]

I like the cleanup. Now I wonder, should we move all_components.hpp to the component folder? Also seems intuitive to me to rename component.hpp to all_components_fwd.hpp, or somehow homogenize the two.

In addition, can we also include component_list in this "revolution"? Perhaps it now belongs in component.hpp and we try to keep all component related stuff in one location only.

[sonarqubecloud]

Quality Gate passed

Issues
11 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[figueroa1395]

One additional thing is that perhaps #1142 (comment) is still relevant. Also, maybe triggering Copilot for review might be useful since missing things for a human due to the nature of this PR is very easy.

Rest looks good, just minor questions.

[figueroa1395]

I'm curious. Why was this necessary? If I understand correctly, this prevents clang-tidy from inserting/removing headers in our Eigen dependency?

[nitbharambe]

We would not want eigen to check includes missing within the Eigen library. It is an option only for misc-include-cleaner.

https://clang.llvm.org/extra/clang-tidy/checks/misc/include-cleaner.html

[mgovers]

but what you're doing now is a global configuration, not a configuration for misc-include-cleaner only

[nitbharambe]

The option name indeed sounded very generic.
But this option is placed under the include cleaner as per https://clang.llvm.org/extra/clang-tidy/checks/misc/include-cleaner.html.
I think it applies to only the include-cleaner because:

• Check for eg. https://clang.llvm.org/extra/clang-tidy/checks/misc/header-include-cycle.html. There is an ignored files mentioned there. Obviously these options might collide with each other.
• Check this search: https://clang.llvm.org/extra/search.html?q=IgnoreHeaders. The option gets mentioned only in the include-cleaner

[mgovers]

The correct syntax for only configuring for a single check is

CheckOptions:
  - key: misc-include-cleaner.IgnoreHeaders
    value: 'Eigen/.*'

Configuring globally is bad practice and even dangerous in the future