Skip to content

Conversation

@MorningStarTM
Copy link

Relates to #1112

Changes proposed in this PR include:

  • Added @overload type hints in buffer_handling.py to improve static typing and mypy inference.
  • No runtime behavior changes; typing-only update.

Could you please pay extra attention to the points below when reviewing the PR:

  • Please review the overload signatures in buffer_handling.py to confirm they match supported runtime inputs and outputs.

Checks

  • Unit tests (pytest) passed locally
  • If changes are related to CI/CD, are they verified via a manual run on this branch? (N/A)

@figueroa1395
Copy link
Member

Hi @MorningStarTM and thanks for your contribution! I have triggered CI (maintainers have to manually activate it for new contributors) and I will assign you to this PR as well as add the respective labels.

On the other hand, I will also review the PR, of course :)

@figueroa1395 figueroa1395 added improvement Improvement on internal implementation good first issue Indicates a good issue for first-time contributors labels Jan 7, 2026
@MorningStarTM
Copy link
Author

Thank you very much! Please let me know if any changes or adjustments are needed.

Copy link
Member

@figueroa1395 figueroa1395 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good! However, CI (ruff) is complaining about formatting (imports), could you fix that, please?

On the other hand, I see other functions in this module could also use @overload; do you want/intend to fix those as well? It is also fine if this PR stays small, any improvements are welcome :)

@MorningStarTM
Copy link
Author

Thanks for the feedback!
I’ll fix the ruff formatting issues and update the PR shortly.
I’ll let you know once it’s done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Indicates a good issue for first-time contributors improvement Improvement on internal implementation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants